Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 2, 2025

Reject cases like function* y({yield}) {} and async function y({await}) {} in scripts (in modules, these were already rejected as yield and await are reserved keywords).

Copy link
Member Author

sapphi-red commented Nov 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 2, 2025

CodSpeed Performance Report

Merging #15221 will not alter performance

Comparing 11-02-fix_parser_reject_yield_and_await_in_object_destructing_shorthand_property_parameters (e551436) with 11-02-fix_parser_reject_for_let.something_of_._ (28ee313)

Summary

✅ 37 untouched

@sapphi-red sapphi-red marked this pull request as ready for review November 2, 2025 09:32
@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_reject_for_let.something_of_._ branch from 560105b to 28ee313 Compare November 2, 2025 10:15
@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_reject_yield_and_await_in_object_destructing_shorthand_property_parameters branch from de9e3eb to e551436 Compare November 2, 2025 10:15
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 2, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 2, 2025

Merge activity

…nd property parameters (#15221)

Reject cases like `function* y({yield}) {}` and `async function y({await}) {}` in scripts (in modules, these were already rejected as `yield` and `await` are reserved keywords).
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_reject_for_let.something_of_._ branch from 28ee313 to 2d6d3a8 Compare November 2, 2025 12:10
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_reject_yield_and_await_in_object_destructing_shorthand_property_parameters branch from e551436 to 837ef21 Compare November 2, 2025 12:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 2, 2025
Base automatically changed from 11-02-fix_parser_reject_for_let.something_of_._ to main November 2, 2025 12:16
@graphite-app graphite-app bot merged commit 837ef21 into main Nov 2, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-02-fix_parser_reject_yield_and_await_in_object_destructing_shorthand_property_parameters branch November 2, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants