Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 7, 2025

Improves error message for imbalanced tokens for blocks.

Before

  × Expected `}` but found `EOF`
   ╭─[typescript/tests/cases/compiler/missingCloseBrace.ts:8:6]
 7 │ 
 8 │     }
   ╰────

After

  × Expected `}` but found `EOF`
   ╭─[typescript/tests/cases/compiler/missingCloseBrace.ts:1:22]
 1 │ function base_init() {
   ·                      ┬
   ·                      ╰── Opened here
 2 │     {
   ╰────
   ╭─[typescript/tests/cases/compiler/missingCloseBrace.ts:8:6]
 7 │ 
 8 │     }
   ╰────

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Nov 7, 2025
Copy link
Member Author

sapphi-red commented Nov 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #15445 will not alter performance

Comparing 11-05-feat_parser_improve_error_message_for_missing_block_closing_tokens (148b776) with main (89adad0)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on 11-05-feat_parser_improve_error_message_for_missing_closing_tokens_that_may_be_followed_by_a_rest_element (bfb3f76) during the generation of this report, so main (89adad0) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red force-pushed the 11-05-feat_parser_improve_error_message_for_missing_closing_tokens_that_may_be_followed_by_a_rest_element branch from 8c7b3e5 to bfb3f76 Compare November 7, 2025 18:33
@sapphi-red sapphi-red force-pushed the 11-05-feat_parser_improve_error_message_for_missing_block_closing_tokens branch from 12205d8 to 148b776 Compare November 7, 2025 18:33
@sapphi-red sapphi-red requested a review from Boshen November 7, 2025 18:38
@sapphi-red sapphi-red marked this pull request as ready for review November 7, 2025 18:38
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 8, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 8, 2025

Merge activity

…15445)

Improves error message for imbalanced tokens for blocks.

**Before**
```
  × Expected `}` but found `EOF`
   ╭─[typescript/tests/cases/compiler/missingCloseBrace.ts:8:6]
 7 │
 8 │     }
   ╰────
```
**After**
```
  × Expected `}` but found `EOF`
   ╭─[typescript/tests/cases/compiler/missingCloseBrace.ts:1:22]
 1 │ function base_init() {
   ·                      ┬
   ·                      ╰── Opened here
 2 │     {
   ╰────
   ╭─[typescript/tests/cases/compiler/missingCloseBrace.ts:8:6]
 7 │
 8 │     }
   ╰────
```
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_improve_error_message_for_missing_closing_tokens_that_may_be_followed_by_a_rest_element branch from bfb3f76 to e1704a4 Compare November 8, 2025 04:34
@graphite-app graphite-app bot force-pushed the 11-05-feat_parser_improve_error_message_for_missing_block_closing_tokens branch from 148b776 to 4decc1d Compare November 8, 2025 04:35
Base automatically changed from 11-05-feat_parser_improve_error_message_for_missing_closing_tokens_that_may_be_followed_by_a_rest_element to main November 8, 2025 04:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 8, 2025
@graphite-app graphite-app bot merged commit 4decc1d into main Nov 8, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-05-feat_parser_improve_error_message_for_missing_block_closing_tokens branch November 8, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants