-
-
Notifications
You must be signed in to change notification settings - Fork 722
feat(parser): improve error messages for missing closing parentheses #15446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): improve error messages for missing closing parentheses #15446
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15446 will not alter performanceComparing Summary
Footnotes |
5d2a124 to
9526fbe
Compare
12205d8 to
148b776
Compare
Merge activity
|
…15446) Improves error message for imbalanced tokens for parentheses. **Before** ``` × Expected `)` but found `}` ╭─[typescript/tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IfStatements/parserErrorRecoveryIfStatement3.ts:4:3] 3 │ if (a.b 4 │ } · ┬ · ╰── `)` expected 5 │ f2() { ╰──── ``` **After** ``` × Expected `)` but found `}` ╭─[typescript/tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IfStatements/parserErrorRecoveryIfStatement3.ts:4:3] 2 │ f1() { 3 │ if (a.b · ┬ · ╰── Opened here 4 │ } · ┬ · ╰── `)` expected 5 │ f2() { ╰──── ```
148b776 to
4decc1d
Compare
9526fbe to
0fa484d
Compare

Improves error message for imbalanced tokens for parentheses.
Before
After