Skip to content

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Nov 11, 2025

Just updated wrongly copied tests.

@github-actions github-actions bot added the A-formatter Area - Formatter label Nov 11, 2025
Copy link
Member Author

leaysgur commented Nov 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 11, 2025
@leaysgur leaysgur force-pushed the 11-11-test_formatter_sort_imports_fix_tests_to_match_with_original branch from 07a8e69 to 04e4bb9 Compare November 11, 2025 04:33
@leaysgur leaysgur marked this pull request as ready for review November 11, 2025 04:34
@leaysgur leaysgur requested a review from Dunqing as a code owner November 11, 2025 04:34
Copilot AI review requested due to automatic review settings November 11, 2025 04:34
Copilot finished reviewing on behalf of leaysgur November 11, 2025 04:35
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
Copy link
Member Author

leaysgur commented Nov 11, 2025

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the test cases for the import sorting functionality to properly validate both sorting behavior and idempotency.

  • Updated the first test case input to be genuinely disordered (previously had some pre-sorted elements)
  • Added a second test case that verifies already-sorted imports remain unchanged (idempotency test)
  • Removed extraneous blank line for cleaner code structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 11, 2025

CodSpeed Performance Report

Merging #15577 will not alter performance

Comparing 11-11-test_formatter_sort_imports_fix_tests_to_match_with_original (04e4bb9) with main (78c3897)1

Summary

✅ 33 untouched
⏩ 4 skipped2

Footnotes

  1. No successful run was found on main (e92276d) during the generation of this report, so 78c3897 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot force-pushed the 11-11-test_formatter_sort_imports_fix_tests_to_match_with_original branch from 04e4bb9 to c9591ea Compare November 11, 2025 04:42
@graphite-app graphite-app bot merged commit c9591ea into main Nov 11, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-11-test_formatter_sort_imports_fix_tests_to_match_with_original branch November 11, 2025 04:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants