Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 11, 2025

We used to use dprint in oxc_ast_tools, but #15064 switched to oxfmt. Remove dprint tool from the "AST changes" CI task.

Copy link
Member Author

overlookmotel commented Nov 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 12:33
Copilot AI review requested due to automatic review settings November 11, 2025 12:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dprint tool dependencies from the "AST Changes" CI workflow, following the migration from dprint to oxfmt in PR #15064.

Key changes:

  • Removed dprint from Rust toolchain setup tools
  • Removed dprint plugin cache restoration step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel marked this pull request as draft November 11, 2025 12:34
@overlookmotel overlookmotel changed the base branch from main to graphite-base/15590 November 11, 2025 12:36
@overlookmotel overlookmotel force-pushed the 11-11-ci_ast_tools_remove_dprint_tool_from_ast_changes_ci_task branch from b311198 to 07f06e8 Compare November 11, 2025 12:37
@overlookmotel overlookmotel changed the base branch from graphite-base/15590 to 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes November 11, 2025 12:37
@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 12:42
@overlookmotel overlookmotel self-assigned this Nov 11, 2025
@overlookmotel
Copy link
Member Author

#15591 made sure that the "AST Changes" task ran on this PR, and it ran without problems. So dprint tool is indeed not required.

So merging without review.

@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools labels Nov 11, 2025
Copy link
Member Author

overlookmotel commented Nov 11, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes branch from 37139a3 to 448cc05 Compare November 11, 2025 12:45
graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
We used to use `dprint` in `oxc_ast_tools`, but #15064 switched to `oxfmt`. Remove `dprint` tool from the "AST changes" CI task.
@graphite-app graphite-app bot force-pushed the 11-11-ci_ast_tools_remove_dprint_tool_from_ast_changes_ci_task branch from 07f06e8 to 575cf86 Compare November 11, 2025 12:46
We used to use `dprint` in `oxc_ast_tools`, but #15064 switched to `oxfmt`. Remove `dprint` tool from the "AST changes" CI task.
@graphite-app graphite-app bot force-pushed the 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes branch from 448cc05 to ec66eb4 Compare November 11, 2025 12:47
@graphite-app graphite-app bot force-pushed the 11-11-ci_ast_tools_remove_dprint_tool_from_ast_changes_ci_task branch from 575cf86 to e389b47 Compare November 11, 2025 12:48
Base automatically changed from 11-11-ci_ast_tools_run_ast_changes_ci_task_when_ci_workflow_file_changes to main November 11, 2025 12:53
@graphite-app graphite-app bot merged commit e389b47 into main Nov 11, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-11-ci_ast_tools_remove_dprint_tool_from_ast_changes_ci_task branch November 11, 2025 12:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants