Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 12, 2025

Simplify the type of analyseOptions object, by introducing a SetNullable utility type (oooh fancy!).

SetNullable is adapted from SetNonNullable from type-fest package.

Copy link
Member Author

overlookmotel commented Nov 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 12, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 12, 2025 15:52
@overlookmotel overlookmotel self-assigned this Nov 12, 2025
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins and removed A-linter Area - Linter labels Nov 12, 2025
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ branch from cf8d55a to f18681e Compare November 12, 2025 15:57
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_add_jsdoc_comments_to_types_related_to_sourcecode_ branch from aae4b21 to 661882e Compare November 12, 2025 15:57
@github-actions github-actions bot added the A-linter Area - Linter label Nov 12, 2025
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_add_jsdoc_comments_to_types_related_to_sourcecode_ branch from 661882e to c466850 Compare November 12, 2025 16:25
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ branch from f18681e to 77b5140 Compare November 12, 2025 16:25
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2025

Merge activity

Simplify the type of `analyseOptions` object, by introducing a `SetNullable` utility type (oooh fancy!).

`SetNullable` is adapted from `SetNonNullable` [from `type-fest` package](https://github.com/sindresorhus/type-fest/blob/2300245cb6f0b28ee36c2bb852ade872254073b8/source/set-non-nullable.d.ts).
@graphite-app graphite-app bot force-pushed the 11-12-refactor_linter_plugins_add_jsdoc_comments_to_types_related_to_sourcecode_ branch from c466850 to cd812bd Compare November 12, 2025 16:42
@graphite-app graphite-app bot force-pushed the 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ branch from 77b5140 to 1a4a7d8 Compare November 12, 2025 16:43
Base automatically changed from 11-12-refactor_linter_plugins_add_jsdoc_comments_to_types_related_to_sourcecode_ to main November 12, 2025 16:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
@graphite-app graphite-app bot merged commit 1a4a7d8 into main Nov 12, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ branch November 12, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants