-
-
Notifications
You must be signed in to change notification settings - Fork 735
refactor(linter/plugins): simplify type for analyzeOptions
#15639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_
Nov 12, 2025
Merged
refactor(linter/plugins): simplify type for analyzeOptions
#15639
graphite-app
merged 1 commit into
main
from
11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_
Nov 12, 2025
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
cf8d55a to
f18681e
Compare
aae4b21 to
661882e
Compare
661882e to
c466850
Compare
f18681e to
77b5140
Compare
This was referenced Nov 12, 2025
Contributor
Merge activity
|
Simplify the type of `analyseOptions` object, by introducing a `SetNullable` utility type (oooh fancy!). `SetNullable` is adapted from `SetNonNullable` [from `type-fest` package](https://github.com/sindresorhus/type-fest/blob/2300245cb6f0b28ee36c2bb852ade872254073b8/source/set-non-nullable.d.ts).
c466850 to
cd812bd
Compare
77b5140 to
1a4a7d8
Compare
Base automatically changed from
11-12-refactor_linter_plugins_add_jsdoc_comments_to_types_related_to_sourcecode_
to
main
November 12, 2025 16:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-cli
Area - CLI
A-linter
Area - Linter
A-linter-plugins
Area - Linter JS plugins
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Simplify the type of
analyseOptionsobject, by introducing aSetNullableutility type (oooh fancy!).SetNullableis adapted fromSetNonNullablefromtype-festpackage.