Skip to content

refactor(linter/plugins): move type defs to top of file in scope.ts #15640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Nov 12, 2025
Merged

refactor(linter/plugins): move type defs to top of file in scope.ts #15640

graphite-app merged 1 commit into from
Nov 12, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 12, 2025 •
edited
Loading

Pure refactor. Just move type defs to top of the file.

This was referenced Nov 12, 2025
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 12, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 12, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 12, 2025 15:52
@overlookmotel overlookmotel self-assigned this Nov 12, 2025
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins and removed A-linter Area - Linter labels Nov 12, 2025
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_move_type_defs_to_top_of_file_in_scope.ts_ branch from fe20673 to 7fb8fc9 Compare November 12, 2025 15:57
@github-actions github-actions bot added the A-linter Area - Linter label Nov 12, 2025
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ branch from f18681e to 77b5140 Compare November 12, 2025 16:25
@overlookmotel overlookmotel force-pushed the 11-12-refactor_linter_plugins_move_type_defs_to_top_of_file_in_scope.ts_ branch from 7fb8fc9 to 20d7468 Compare November 12, 2025 16:25
This was referenced Nov 12, 2025
Merged
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ branch from 77b5140 to 1a4a7d8 Compare November 12, 2025 16:43
graphite-app bot pushed a commit that referenced this pull request Nov 12, 2025
@overlookmotel
refactor(linter/plugins): move type defs to top of file in scope.ts (…
16fd064 
…#15640)

Pure refactor. Just move type defs to top of the file.
@graphite-app graphite-app bot force-pushed the 11-12-refactor_linter_plugins_move_type_defs_to_top_of_file_in_scope.ts_ branch from 20d7468 to 16fd064 Compare November 12, 2025 16:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
Base automatically changed from 11-12-refactor_linter_plugins_simplify_type_for_analyzeoptions_ to main November 12, 2025 16:49
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
@overlookmotel
refactor(linter/plugins): move type defs to top of file in scope.ts (…
9f5ad7e 
…#15640)

Pure refactor. Just move type defs to top of the file.
Copilot AI review requested due to automatic review settings November 12, 2025 17:57
@graphite-app graphite-app bot force-pushed the 11-12-refactor_linter_plugins_move_type_defs_to_top_of_file_in_scope.ts_ branch from 16fd064 to 9f5ad7e Compare November 12, 2025 17:57
Copilot AI reviewed Nov 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 9f5ad7e into main Nov 12, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-12-refactor_linter_plugins_move_type_defs_to_top_of_file_in_scope.ts_ branch November 12, 2025 18:03
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel