Skip to content

test(linter/plugins): rename dirs in nested tests #15888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Nov 20, 2025
Merged

test(linter/plugins): rename dirs in nested tests #15888

graphite-app merged 1 commit into from
Nov 20, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 19, 2025 •
edited
Loading

Rename the directories containing files to lint in the nested config tests from nested to files, to match the rest, and only lint the files directories.

I don't think this has any effect on the operation of the tests, but makes it easier to lint these directories as part of the repo (#15887).

This also removes the need for overrideFiles property in testFixture function's options, so remove it.

@overlookmotel overlookmotel mentioned this pull request Nov 19, 2025
Merged
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 19, 2025
This was referenced Nov 19, 2025
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 19, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Nov 19, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review November 19, 2025 22:48
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Nov 19, 2025
@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 19, 2025 •
edited
Loading

@camc314 I don't think the custom_plugin_nested_config_duplicate test is doing what it's meant to.

oxc/apps/oxlint/test/fixtures/custom_plugin_nested_config_duplicate/files/.oxlintrc.json

Lines 1 to 4 in 65e0f91

{
"plugins": ["../plugin.ts"],
"extends": ["../.oxlintrc.json"]
}

plugins should be jsPlugins here I think. But I don't know what it's meant to be testing, so don't know how to fix it.

I'm also not sure why the invalid value in plugins didn't result in an error.

@camc314 camc314 mentioned this pull request Nov 20, 2025
Open
@overlookmotel overlookmotel force-pushed the 11-19-refactor_linter_plugins_enable_ts_strictnullchecks_ branch from 4231c2a to 7f6d381 Compare November 20, 2025 13:48
@overlookmotel overlookmotel force-pushed the 11-19-test_linter_plugins_rename_dirs_in_nested_tests branch from 65e0f91 to 78945ca Compare November 20, 2025 13:48
@overlookmotel overlookmotel mentioned this pull request Nov 20, 2025
Merged
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Nov 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
test(linter/plugins): rename dirs in nested tests (#15888)
6ce2f7a 
Rename the directories containing files to lint in the nested config tests from `nested` to `files`, to match the rest, and only lint the `files` directories.

I don't think this has any effect on the operation of the tests, but makes it easier to lint these directories as part of the repo (#15887).

This also removes the need for `overrideFiles` property in `testFixture` function's options, so remove it.
@graphite-app graphite-app bot force-pushed the 11-19-refactor_linter_plugins_enable_ts_strictnullchecks_ branch from 7f6d381 to a72b093 Compare November 20, 2025 15:52
@graphite-app graphite-app bot force-pushed the 11-19-test_linter_plugins_rename_dirs_in_nested_tests branch from 78945ca to 6ce2f7a Compare November 20, 2025 15:53
Base automatically changed from 11-19-refactor_linter_plugins_enable_ts_strictnullchecks_ to main November 20, 2025 15:58
@graphite-app graphite-app bot merged commit 6ce2f7a into main Nov 20, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-19-test_linter_plugins_rename_dirs_in_nested_tests branch November 20, 2025 15:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 20, 2025
This was referenced Nov 20, 2025
Merged
Merged
Merged
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
@overlookmotel
test(linter/plugins): rename dirs in nested tests (#15888)
cd58a88 
Rename the directories containing files to lint in the nested config tests from `nested` to `files`, to match the rest, and only lint the `files` directories.

I don't think this has any effect on the operation of the tests, but makes it easier to lint these directories as part of the repo (#15887).

This also removes the need for `overrideFiles` property in `testFixture` function's options, so remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314