Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 20, 2025

Remove the need to list every fixture in e2e.test.ts file by automatically running tests on every fixture in test/fixtures directory.

Running Oxlint with --fix and running fixtures with ESLint is now controlled by adding an options.json file to the fixture directory contining e.g. { "fix": true } or { "eslint": true }.

Now we can add a new fixture just by creating a new directory in fixtures.

Copy link
Member Author

overlookmotel commented Nov 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 20, 2025 13:54
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Nov 20, 2025
@overlookmotel overlookmotel force-pushed the 11-20-test_linter_plugins_automate_testing_all_fixtures branch from 8154362 to 211e558 Compare November 20, 2025 14:10
@graphite-app graphite-app bot changed the base branch from 11-19-ci_linter_plugins_lint_apps_oxlint_with_oxlint to graphite-base/15911 November 20, 2025 15:53
@graphite-app graphite-app bot force-pushed the graphite-base/15911 branch from b24574d to 6ce2f7a Compare November 20, 2025 15:59
@graphite-app graphite-app bot force-pushed the 11-20-test_linter_plugins_automate_testing_all_fixtures branch from 211e558 to 7e63a01 Compare November 20, 2025 15:59
@graphite-app graphite-app bot changed the base branch from graphite-base/15911 to main November 20, 2025 15:59
@graphite-app graphite-app bot force-pushed the 11-20-test_linter_plugins_automate_testing_all_fixtures branch 2 times, most recently from 29acf30 to bbf261e Compare November 20, 2025 16:22
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025
Copy link
Contributor

camc314 commented Nov 21, 2025

Merge activity

Remove the need to list every fixture in `e2e.test.ts` file by automatically running tests on every fixture in `test/fixtures` directory.

Running Oxlint with `--fix` and running fixtures with ESLint is now controlled by adding an `options.json` file to the fixture directory contining e.g. `{ "fix": true }` or `{ "eslint": true }`.

Now we can add a new fixture just by creating a new directory in `fixtures`.
Copilot AI review requested due to automatic review settings November 21, 2025 11:38
@graphite-app graphite-app bot force-pushed the 11-20-test_linter_plugins_automate_testing_all_fixtures branch from bbf261e to ca7a6d3 Compare November 21, 2025 11:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit ca7a6d3 into main Nov 21, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-20-test_linter_plugins_automate_testing_all_fixtures branch November 21, 2025 11:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
Remove the need to list every fixture in `e2e.test.ts` file by automatically running tests on every fixture in `test/fixtures` directory.

Running Oxlint with `--fix` and running fixtures with ESLint is now controlled by adding an `options.json` file to the fixture directory contining e.g. `{ "fix": true }` or `{ "eslint": true }`.

Now we can add a new fixture just by creating a new directory in `fixtures`.
graphite-app bot pushed a commit that referenced this pull request Nov 22, 2025
#15911 broke NAPI tests on Windows, because it failed to replace `\` with `/` in file paths in snapshots.

https://github.com/oxc-project/oxc/actions/runs/19581028169/job/56078684915#step:8:479

Fix this by normalizing slashes in file paths before outputting them in snapshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants