-
-
Notifications
You must be signed in to change notification settings - Fork 734
test(linter/plugins): automate testing all fixtures #15911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
11-20-test_linter_plugins_automate_testing_all_fixtures
Nov 21, 2025
Merged
test(linter/plugins): automate testing all fixtures #15911
graphite-app
merged 1 commit into
main
from
11-20-test_linter_plugins_automate_testing_all_fixtures
Nov 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2025
Member
Author
8154362 to
211e558
Compare
b24574d to
6ce2f7a
Compare
211e558 to
7e63a01
Compare
29acf30 to
bbf261e
Compare
This was referenced Nov 20, 2025
camc314
approved these changes
Nov 21, 2025
Contributor
Merge activity
|
Remove the need to list every fixture in `e2e.test.ts` file by automatically running tests on every fixture in `test/fixtures` directory.
Running Oxlint with `--fix` and running fixtures with ESLint is now controlled by adding an `options.json` file to the fixture directory contining e.g. `{ "fix": true }` or `{ "eslint": true }`.
Now we can add a new fixture just by creating a new directory in `fixtures`.
bbf261e to
ca7a6d3
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Copilot AI
pushed a commit
that referenced
this pull request
Nov 21, 2025
Remove the need to list every fixture in `e2e.test.ts` file by automatically running tests on every fixture in `test/fixtures` directory.
Running Oxlint with `--fix` and running fixtures with ESLint is now controlled by adding an `options.json` file to the fixture directory contining e.g. `{ "fix": true }` or `{ "eslint": true }`.
Now we can add a new fixture just by creating a new directory in `fixtures`.
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 22, 2025
#15911 broke NAPI tests on Windows, because it failed to replace `\` with `/` in file paths in snapshots. https://github.com/oxc-project/oxc/actions/runs/19581028169/job/56078684915#step:8:479 Fix this by normalizing slashes in file paths before outputting them in snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-cli
Area - CLI
A-linter
Area - Linter
A-linter-plugins
Area - Linter JS plugins
C-test
Category - Testing. Code is missing test cases, or a PR is adding them
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Remove the need to list every fixture in
e2e.test.tsfile by automatically running tests on every fixture intest/fixturesdirectory.Running Oxlint with
--fixand running fixtures with ESLint is now controlled by adding anoptions.jsonfile to the fixture directory contining e.g.{ "fix": true }or{ "eslint": true }.Now we can add a new fixture just by creating a new directory in
fixtures.