Skip to content

ci(apps, napi): skip linting files generated by NAPI-RS #16013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2025
Merged

ci(apps, napi): skip linting files generated by NAPI-RS #16013

merged 1 commit into from
Nov 23, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 23, 2025 •
edited
Loading

Disable Oxlint for files generated by NAPI-RS.

These files already have /* eslint-disable */ comments, but some of those comments are unnecessary, so linting them generates "Unused eslint-disable directive" errors.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 23, 2025
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review November 23, 2025 22:55
Copilot AI review requested due to automatic review settings November 23, 2025 22:55
@overlookmotel overlookmotel self-assigned this Nov 23, 2025
Copilot finished reviewing on behalf of overlookmotel November 23, 2025 22:59
Copilot AI reviewed Nov 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds ignore patterns to oxlintrc.json to exclude NAPI-RS generated files from linting. These files contain /* eslint-disable */ comments that can cause "Unused eslint-disable directive" warnings when linted.

Key changes:

  • Added 7 new ignore patterns for NAPI-RS generated files including .d.ts, .wasi.cjs, wasi-worker-browser.mjs, and webcontainer-fallback.cjs files
  • Patterns target files in the napi/ directory structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel force-pushed the 11-23-ci_apps_napi_skip_linting_files_generated_by_napi-rs branch 2 times, most recently from a3bb641 to deefcb0 Compare November 23, 2025 23:09
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 23, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 23, 2025 •
edited
Loading

Merge activity

@overlookmotel
ci(apps, napi): skip linting files generated by NAPI-RS (#16013)
1ea385c 
Disable Oxlint for files generated by NAPI-RS.

These files already have `/* eslint-disable */` comments, but some of those comments are unnecessary, so linting them generates "Unused eslint-disable directive" errors.
@graphite-app graphite-app bot force-pushed the 11-23-ci_apps_napi_skip_linting_files_generated_by_napi-rs branch from deefcb0 to 1ea385c Compare November 23, 2025 23:19
@graphite-app graphite-app bot merged commit 1ea385c into main Nov 23, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-23-ci_apps_napi_skip_linting_files_generated_by_napi-rs branch November 23, 2025 23:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 23, 2025
graphite-app bot pushed a commit that referenced this pull request Nov 24, 2025
@overlookmotel
ci(tools): linting check for unused disable directives (#16015)
5156ca8 
After #16013, #16014, and #16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
overlookmotel added a commit that referenced this pull request Nov 24, 2025
@overlookmotel
ci(tools): linting check for unused disable directives (#16015)
67b9d14 
After #16013, #16014, and #16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
graphite-app bot pushed a commit that referenced this pull request Nov 24, 2025
@overlookmotel
ci(tools): linting check for unused disable directives (#16015)
9f7272a 
After #16013, #16014, and #16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel