Skip to content

ci(tools): linting check for unused disable directives #16015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

ci(tools): linting check for unused disable directives #16015

merged 1 commit into from
Nov 24, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 23, 2025 •
edited
Loading

After #16013, #16014, and #16053, we can now enable checking for unused oxlint-disable comments in our linting setup.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 23, 2025
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review November 23, 2025 22:57
@overlookmotel overlookmotel mentioned this pull request Nov 23, 2025
Merged
@overlookmotel overlookmotel self-assigned this Nov 23, 2025
@overlookmotel overlookmotel force-pushed the 11-23-fix_apps_editors_napi_fix_oxlint-disable_comments branch from fcfb715 to cf793c2 Compare November 23, 2025 22:59
@overlookmotel overlookmotel force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch 2 times, most recently from 3ef58bb to f680f25 Compare November 23, 2025 23:09
@overlookmotel overlookmotel force-pushed the 11-23-fix_apps_editors_napi_fix_oxlint-disable_comments branch from cf793c2 to be72a58 Compare November 23, 2025 23:09
@overlookmotel overlookmotel marked this pull request as draft November 23, 2025 23:12
@graphite-app graphite-app bot changed the base branch from 11-23-fix_apps_editors_napi_fix_oxlint-disable_comments to graphite-base/16015 November 23, 2025 23:20
@graphite-app graphite-app bot force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch from f680f25 to aaab05c Compare November 23, 2025 23:30
@graphite-app graphite-app bot force-pushed the graphite-base/16015 branch from be72a58 to 2bd3cb6 Compare November 23, 2025 23:30
@graphite-app graphite-app bot changed the base branch from graphite-base/16015 to main November 23, 2025 23:30
@graphite-app graphite-app bot force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch from aaab05c to e70c962 Compare November 23, 2025 23:31
@overlookmotel overlookmotel changed the base branch from main to graphite-base/16015 November 24, 2025 11:33
@overlookmotel overlookmotel force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch from e70c962 to a316c74 Compare November 24, 2025 11:33
@overlookmotel overlookmotel changed the base branch from graphite-base/16015 to 11-24-ci_lint_enable_no-console_rule November 24, 2025 11:33
@overlookmotel overlookmotel mentioned this pull request Nov 24, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review November 24, 2025 11:36
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Nov 24, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 24, 11:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 24, 11:54 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 24, 12:12 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Lint').
  • Nov 24, 1:31 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 24, 1:31 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Nov 24, 1:38 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 11-24-ci_lint_enable_no-console_rule branch from 3b33da5 to 5877752 Compare November 24, 2025 12:06
graphite-app bot pushed a commit that referenced this pull request Nov 24, 2025
@overlookmotel
ci(tools): linting check for unused disable directives (#16015)
5156ca8 
After #16013, #16014, and #16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
@graphite-app graphite-app bot force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch from a316c74 to 5156ca8 Compare November 24, 2025 12:06
Base automatically changed from 11-24-ci_lint_enable_no-console_rule to main November 24, 2025 12:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
@overlookmotel overlookmotel changed the base branch from main to graphite-base/16015 November 24, 2025 13:12
overlookmotel added a commit that referenced this pull request Nov 24, 2025
@overlookmotel
ci(tools): linting check for unused disable directives (#16015)
67b9d14 
After #16013, #16014, and #16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
@overlookmotel overlookmotel force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch from 5156ca8 to 67b9d14 Compare November 24, 2025 13:12
@overlookmotel overlookmotel changed the base branch from graphite-base/16015 to 11-24-refactor_napi_parser_remove_unused_oxlint-disable_comment November 24, 2025 13:13
@overlookmotel overlookmotel mentioned this pull request Nov 24, 2025
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
@overlookmotel
ci(tools): linting check for unused disable directives (#16015)
9f7272a 
After #16013, #16014, and #16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
@graphite-app graphite-app bot force-pushed the 11-24-refactor_napi_parser_remove_unused_oxlint-disable_comment branch from 0902acb to b42610c Compare November 24, 2025 13:32
@graphite-app graphite-app bot force-pushed the 11-23-ci_tools_linting_check_for_unused_disable_directives branch from 67b9d14 to 9f7272a Compare November 24, 2025 13:32
@Sysix Sysix mentioned this pull request Nov 24, 2025
Merged
@graphite-app graphite-app bot changed the base branch from 11-24-refactor_napi_parser_remove_unused_oxlint-disable_comment to main November 24, 2025 13:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
@graphite-app graphite-app bot merged commit 9f7272a into main Nov 24, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-23-ci_tools_linting_check_for_unused_disable_directives branch November 24, 2025 13:39
graphite-app bot pushed a commit that referenced this pull request Nov 24, 2025
@Sysix
chore(dx): report unused disable directives for vscode extension (#16059
0069b04 
)

follow up from #16015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@overlookmotel overlookmotel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314