feat(napi)!: drop armv7-unknown-linux-musleabihf support
#16105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Copilot finished reviewing on behalf of
Boshen
November 25, 2025 12:50
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes support for the armv7-unknown-linux-musleabihf target platform and adds support for OpenHarmony OS (aarch64-unknown-linux-ohos) across the NAPI packages. The changes maintain alphabetical ordering of target platforms and update both the package configurations and CI/CD workflows to reflect these platform changes.
Key Changes
- Removed
armv7-unknown-linux-musleabihffrom all NAPI package targets and GitHub Actions workflow - Added
aarch64-unknown-linux-ohostarget to all NAPI packages (parser, transform, minify) - Updated CI workflow to include OpenHarmony SDK setup step for building OHOS targets
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
napi/transform/package.json |
Updated target list: removed armv7 musl target, added OHOS target, alphabetically sorted |
napi/parser/package.json |
Updated target list: removed armv7 musl target, added OHOS target, alphabetically sorted |
napi/minify/package.json |
Updated target list: removed armv7 musl target, added OHOS target, alphabetically sorted |
.github/workflows/reusable_release_napi.yml |
Removed armv7 musl build job, added OHOS build job with SDK setup step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Boshen
force-pushed
the
11-25-feat_napi_drop_armv7-unknown-linux-musleabihf_support
branch
from
e3fdf4e to
849357b
Compare
Contributor
Merge activity
|
Also add `aarch64-unknown-linux-ohos` support. `armv7-unknown-linux-musleabihf` target is broken for a while (nodejs/node#53489) and is a legacy target. part of #16094
graphite-app
bot
force-pushed
the
11-25-feat_napi_drop_armv7-unknown-linux-musleabihf_support
branch
from
849357b to
934d873
Compare
graphite-app
bot
deleted the
11-25-feat_napi_drop_armv7-unknown-linux-musleabihf_support
branch
overlookmotel
pushed a commit
that referenced
this pull request
Dec 1, 2025
### 💥 BREAKING CHANGES - 74cf572 ast: [**BREAKING**] Make `source` field of `TSImportType` a `StringLiteral` (#16114) (copilot-swe-agent) - 43156ae ast: [**BREAKING**] Rename `TSImportType` `argument` field to `source` (#16110) (overlookmotel) - 934d873 napi: [**BREAKING**] Drop `armv7-unknown-linux-musleabihf` support (#16105) (Boshen) ### 🚀 Features - 669afe0 ast: Add `Expression::is_jsx` method (#16154) (Dunqing) - 17a8caa parser: Add diagnostic for JSX identifiers with hyphens (#16133) (camchenry) - 0549ae5 parser: Add diagnostic for expected ident after optional chain (#16132) (camchenry) - db839ae parser: Improve diagnostic for unexpected optional declarations (#16131) (camchenry) - bab4bc8 napi/parser: Add type annotations to parse-raw-worker test (#15998) (camc314) ### 🐛 Bug Fixes - 35ed36c traverse: Fix panic when truncating non-ASCII variable names (#16265) (peter) - 9149a26 linter/plugins, napi/parser: Deep freeze visitor keys (#16293) (overlookmotel) - 6b54dab minifier: Incorrect non-null object condition simplification with `&&` and `||` (#16161) (sapphi-red) - 9cc20a1 minifier: Avoid merging side effectful expressions to next assignment statement if the side effect may change the left hand side reference (#16165) (sapphi-red) - 91eb3f2 ast/estree: Convert `TSImportType` `argument` field to `Literal` (#16109) (overlookmotel) - 1199cee parser: Reject invalid modifiers on parameter properties with binding patterns (#16083) (camc314) - f376325 traverse: Remove `console.log` from build script (#16049) (overlookmotel) ### ⚡ Performance - 82d784f lexer: Reduce bounds checks in `Lexer::get_string` (#16317) (overlookmotel) - cc2f352 span: Add `#[inline]` to `Atom` methods (#16311) (overlookmotel) - ffca070 span: Add `#[repr(transparent)]` to `Atom` (#16310) (overlookmotel) - 02bdf90 linter/plugins, napi/parser: Reuse arrays in visitor keys (#16294) (overlookmotel) ### 📚 Documentation - 891e0b4 parser: Add note about falling back to parse TSType in TSImportType (#16119) (camc314) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
aarch64-unknown-linux-ohossupport.armv7-unknown-linux-musleabihftarget is broken for a while (nodejs/node#53489) and is a legacy target.part of #16094