Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 26, 2025

    /// Returns `true` if this [`Expression`] is a [`JSXElement`] or [`JSXFragment`].
    pub fn is_jsx(&self) -> bool {
        matches!(self, Self::JSXElement(_) | Self::JSXFragment(_))
    }

@github-actions github-actions bot added the A-ast Area - AST label Nov 26, 2025
Copy link
Member Author

Dunqing commented Nov 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a convenience method is_jsx() to the Expression type in the AST implementation. The method provides a simple boolean check to determine if an expression is a JSX element or fragment, consolidating a pattern that appears frequently throughout the codebase.

Key changes:

  • Adds Expression::is_jsx() method that returns true for JSXElement and JSXFragment variants
  • Follows existing code patterns for similar type-checking methods like is_typescript_syntax() and is_assignment()
  • Provides a cleaner alternative to the repeated pattern matches!(expr, Expression::JSXElement(_) | Expression::JSXFragment(_)) found across multiple crates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #16154 will not alter performance

Comparing 11-26-feat_ast_add_expression_is_jsx_method (6f7e6b1) with main (17a8caa)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (be0500e) during the generation of this report, so 17a8caa was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2025

Merge activity

```rs
    /// Returns `true` if this [`Expression`] is a [`JSXElement`] or [`JSXFragment`].
    pub fn is_jsx(&self) -> bool {
        matches!(self, Self::JSXElement(_) | Self::JSXFragment(_))
    }
```
@graphite-app graphite-app bot force-pushed the 11-26-feat_ast_add_expression_is_jsx_method branch from 6f7e6b1 to 669afe0 Compare November 26, 2025 11:30
@graphite-app graphite-app bot merged commit 669afe0 into main Nov 26, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-26-feat_ast_add_expression_is_jsx_method branch November 26, 2025 11:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
overlookmotel pushed a commit that referenced this pull request Dec 1, 2025
### 💥 BREAKING CHANGES

- 74cf572 ast: [**BREAKING**] Make `source` field of `TSImportType` a
`StringLiteral` (#16114) (copilot-swe-agent)
- 43156ae ast: [**BREAKING**] Rename `TSImportType` `argument` field to
`source` (#16110) (overlookmotel)
- 934d873 napi: [**BREAKING**] Drop `armv7-unknown-linux-musleabihf`
support (#16105) (Boshen)

### 🚀 Features

- 669afe0 ast: Add `Expression::is_jsx` method (#16154) (Dunqing)
- 17a8caa parser: Add diagnostic for JSX identifiers with hyphens
(#16133) (camchenry)
- 0549ae5 parser: Add diagnostic for expected ident after optional chain
(#16132) (camchenry)
- db839ae parser: Improve diagnostic for unexpected optional
declarations (#16131) (camchenry)
- bab4bc8 napi/parser: Add type annotations to parse-raw-worker test
(#15998) (camc314)

### 🐛 Bug Fixes

- 35ed36c traverse: Fix panic when truncating non-ASCII variable names
(#16265) (peter)
- 9149a26 linter/plugins, napi/parser: Deep freeze visitor keys (#16293)
(overlookmotel)
- 6b54dab minifier: Incorrect non-null object condition simplification
with `&&` and `||` (#16161) (sapphi-red)
- 9cc20a1 minifier: Avoid merging side effectful expressions to next
assignment statement if the side effect may change the left hand side
reference (#16165) (sapphi-red)
- 91eb3f2 ast/estree: Convert `TSImportType` `argument` field to
`Literal` (#16109) (overlookmotel)
- 1199cee parser: Reject invalid modifiers on parameter properties with
binding patterns (#16083) (camc314)
- f376325 traverse: Remove `console.log` from build script (#16049)
(overlookmotel)

### ⚡ Performance

- 82d784f lexer: Reduce bounds checks in `Lexer::get_string` (#16317)
(overlookmotel)
- cc2f352 span: Add `#[inline]` to `Atom` methods (#16311)
(overlookmotel)
- ffca070 span: Add `#[repr(transparent)]` to `Atom` (#16310)
(overlookmotel)
- 02bdf90 linter/plugins, napi/parser: Reuse arrays in visitor keys
(#16294) (overlookmotel)

### 📚 Documentation

- 891e0b4 parser: Add note about falling back to parse TSType in
TSImportType (#16119) (camc314)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants