Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-jest/no-large-snapshot #3436

Merged
merged 9 commits into from
Jun 2, 2024

Conversation

eryue0220
Copy link
Contributor

part of #492

Rule Detail: link

Copy link

graphite-app bot commented May 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label May 27, 2024
Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #3436 will not alter performance

Comparing eryue0220:feat/jest-no-large-snapshots (8e04a84) with main (ac66de6)

Summary

✅ 22 untouched benchmarks

@Boshen Boshen requested a review from mysteryven May 28, 2024 01:57
@mysteryven
Copy link
Member

I'll take a close look at these PRs after several hours.

crates/oxc_linter/src/rules/jest/no_large_snapshots.rs Outdated Show resolved Hide resolved
crates/oxc_span/src/source_type.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/jest/no_large_snapshots.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/jest/no_large_snapshots.rs Outdated Show resolved Hide resolved
@mysteryven
Copy link
Member

I want to merge this PR, so I updated the get_line_count fn myself, if you find this way it not a correct, you can pull another PR :)

@mysteryven mysteryven merged commit daf559f into oxc-project:main Jun 2, 2024
23 checks passed
@eryue0220 eryue0220 deleted the feat/jest-no-large-snapshots branch June 4, 2024 23:39
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.4.3] - 2024-06-07

### Features

- 1fb9d23 linter: Add fixer for no-useless-fallback-in-spread rule
(#3544) (Don Isaac)
- 6506d08 linter: Add fixer for no-single-promise-in-promise-methods
(#3531) (Don Isaac)
- daf559f linter: Eslint-plugin-jest/no-large-snapshot (#3436) (cinchen)
- 4c17bc6 linter: Eslint/no-constructor-return (#3321) (谭光志)
- 4a075cc linter/jsdoc: Implement require-param rule (#3554) (Yuji
Sugiura)
- 747500a linter/jsdoc: Implement require-returns-type rule (#3458)
(Yuji Sugiura)
- 6b39654 linter/tree-shaking: Support options (#3504) (Wang Wenzhe)
- 0cdb45a oxc_codegen: Preserve annotate comment (#3465)
(IWANABETHATGUY)

### Bug Fixes

- b188778 linter/eslint: Fix `require-await` false positives in
`ForOfStatement`. (#3457) (rzvxa)
- 350cd91 parser: Should parser error when function declaration has no
name (#3461) (Dunqing)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants