Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ eslint-plugin-jest #492

Open
Boshen opened this issue Jun 28, 2023 · 2 comments
Open

☂️ eslint-plugin-jest #492

Boshen opened this issue Jun 28, 2023 · 2 comments
Assignees
@mysteryven
Labels
A-linter Area - Linter good first issue Experience Level - Good for newcomers

Comments

@Boshen
Copy link
Member

Boshen commented Jun 28, 2023 •
edited by github-actions bot
Loading

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for eslint-plugin-jest.

There are 62(+ 0 deprecated) rules.

  • 1/19 recommended rules are remaining as TODO
  • 13/43 not recommended rules are remaining as TODO

To get started, run the following command:

just new-jest-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✨: 18, 🚫: 0 / total: 19
Status Name Docs
✨ jest/expect-expect https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/expect-expect.md
✨ jest/no-alias-methods https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-alias-methods.md
✨ jest/no-commented-out-tests https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-commented-out-tests.md
✨ jest/no-conditional-expect https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-conditional-expect.md
✨ jest/no-deprecated-functions https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-deprecated-functions.md
✨ jest/no-disabled-tests https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-disabled-tests.md
✨ jest/no-done-callback https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-done-callback.md
✨ jest/no-export https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-export.md
✨ jest/no-focused-tests https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-focused-tests.md
✨ jest/no-identical-title https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-identical-title.md
✨ jest/no-interpolation-in-snapshots https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-interpolation-in-snapshots.md
✨ jest/no-jasmine-globals https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-jasmine-globals.md
✨ jest/no-mocks-import https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-mocks-import.md
✨ jest/no-standalone-expect https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-standalone-expect.md
✨ jest/no-test-prefixes https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-test-prefixes.md
✨ jest/valid-describe-callback https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/valid-describe-callback.md
jest/valid-expect-in-promise https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/valid-expect-in-promise.md
✨ jest/valid-expect https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/valid-expect.md
✨ jest/valid-title https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/valid-title.md

✨ = Implemented, 🚫 = No need to implement

Not recommended rules

✨: 30, 🚫: 0 / total: 43
Status Name Docs
✨ jest/consistent-test-it https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/consistent-test-it.md
✨ jest/max-expects https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/max-expects.md
✨ jest/max-nested-describe https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/max-nested-describe.md
✨ jest/no-conditional-in-test https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-conditional-in-test.md
✨ jest/no-confusing-set-timeout https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-confusing-set-timeout.md
✨ jest/no-duplicate-hooks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-duplicate-hooks.md
✨ jest/no-hooks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-hooks.md
✨ jest/no-large-snapshots https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-large-snapshots.md
✨ jest/no-restricted-jest-methods https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-restricted-jest-methods.md
✨ jest/no-restricted-matchers https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-restricted-matchers.md
✨ jest/no-test-return-statement https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-test-return-statement.md
✨ jest/no-untyped-mock-factory https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/no-untyped-mock-factory.md
jest/padding-around-after-all-blocks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-after-all-blocks.md
jest/padding-around-after-each-blocks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-after-each-blocks.md
jest/padding-around-all https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-all.md
jest/padding-around-before-all-blocks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-before-all-blocks.md
jest/padding-around-before-each-blocks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-before-each-blocks.md
jest/padding-around-describe-blocks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-describe-blocks.md
jest/padding-around-expect-groups https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-expect-groups.md
jest/padding-around-test-blocks https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/padding-around-test-blocks.md
✨ jest/prefer-called-with https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-called-with.md
✨ jest/prefer-comparison-matcher https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-comparison-matcher.md
jest/prefer-each https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-each.md
✨ jest/prefer-equality-matcher https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-equality-matcher.md
jest/prefer-expect-assertions https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-expect-assertions.md
✨ jest/prefer-expect-resolves https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-expect-resolves.md
✨ jest/prefer-hooks-in-order https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-hooks-in-order.md
✨ jest/prefer-hooks-on-top https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-hooks-on-top.md
jest/prefer-importing-jest-globals https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-importing-jest-globals.md
✨ jest/prefer-jest-mocked https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-jest-mocked.md
✨ jest/prefer-lowercase-title https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-lowercase-title.md
✨ jest/prefer-mock-promise-shorthand https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-mock-promise-shorthand.md
jest/prefer-snapshot-hint https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-snapshot-hint.md
✨ jest/prefer-spy-on https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-spy-on.md
✨ jest/prefer-strict-equal https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-strict-equal.md
✨ jest/prefer-to-be https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-to-be.md
✨ jest/prefer-to-contain https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-to-contain.md
✨ jest/prefer-to-have-length https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-to-have-length.md
✨ jest/prefer-todo https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/prefer-todo.md
✨ jest/require-hook https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/require-hook.md
✨ jest/require-to-throw-message https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/require-to-throw-message.md
✨ jest/require-top-level-describe https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/require-top-level-describe.md
jest/unbound-method https://github.com/jest-community/eslint-plugin-jest/blob/v28.9.0/docs/rules/unbound-method.md

✨ = Implemented, 🚫 = No need to implement
@Boshen Boshen mentioned this issue Jun 28, 2023
Open
@Boshen Boshen added good first issue Experience Level - Good for newcomers A-linter Area - Linter labels Jul 5, 2023
@Boshen

This comment was marked as outdated.

Sign in to view
@cijiugechu cijiugechu mentioned this issue Jul 9, 2023
Merged
@camc314 camc314 mentioned this issue Nov 12, 2023
Merged
@mysteryven mysteryven mentioned this issue Nov 14, 2023
Merged
@Boshen Boshen changed the title ☂️ linter: eslint-plugin-jest recommended rules ☂️ eslint-plugin-jest Jan 26, 2024
@keita-hino
Copy link
Contributor

I will start working on the task of jest/require-to-throw-message.

@keita-hino keita-hino mentioned this issue Feb 11, 2024
Merged
mysteryven pushed a commit that referenced this issue Feb 11, 2024
@keita-hino
feat(linter): eslint-plugin-jest require-to-throw-message (#2384)
8d6202f 
partof: #492 

docs:
https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-to-throw-message.md
code:
https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/require-to-throw-message.ts
test:
https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/__tests__/require-to-throw-message.test.ts
@eryue0220 eryue0220 mentioned this issue Mar 30, 2024
Merged
mysteryven pushed a commit that referenced this issue Apr 3, 2024
@eryue0220
feat(linter): eslint-plugin-jest/prefer-mock-promise-sorthand (#2864)
7bc638e 
part of #492 

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-mock-promise-shorthand.ts)
@eryue0220 eryue0220 mentioned this issue Apr 7, 2024
Merged
@leaysgur leaysgur mentioned this issue Apr 8, 2024
Merged
Boshen pushed a commit that referenced this issue Apr 8, 2024
@leaysgur
fix(tasks/lint_rules): Fix plugin-jest rules collector (#2915)
a0fe504 
Fixes umbrella issue for
[`plugin-jest`](#492) to render
recommended rules section properly.

- - -

Along with sticking legacy ESLint.
Since `eslint@latest` is now v9 and it removed `Linter#defineRule()` and
`Linter#getRules()` which we use heavily...
mysteryven pushed a commit that referenced this issue Apr 10, 2024
@eryue0220
feat(linter): eslint-plugin-jest/prefer-lowercase-title (#2911)
6757dba 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-lowercase-title.ts)
@eryue0220 eryue0220 mentioned this issue Apr 26, 2024
Merged
mysteryven pushed a commit that referenced this issue Apr 26, 2024
@eryue0220
feat(linter): eslint-plugin-jest/require-hook (#3110)
bef8a71 
part of #492

Rule Detail: [link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/require-hook.ts)
@eryue0220 eryue0220 mentioned this issue Apr 30, 2024
Draft
@eryue0220 eryue0220 mentioned this issue May 20, 2024
Merged
mysteryven pushed a commit that referenced this issue May 20, 2024
@eryue0220
feat(linter): eslint-plugin-jest/no-duplicate-hooks (#3358)
aec613b 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/no-duplicate-hooks.ts)
This was referenced May 27, 2024
Merged
Merged
Merged
mysteryven pushed a commit that referenced this issue May 28, 2024
@eryue0220
feat(linter): eslint-plugin-jest/prefer-hooks-on-top (#3437)
edaa555 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-hooks-on-top.ts)
mysteryven added a commit that referenced this issue May 28, 2024
@eryue0220 @mysteryven
feat(linter): eslint-plugin-jest/require-top-level-describe (#3439)
ded59bc 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/require-top-level-describe.ts)

---------

Co-authored-by: wenzhe <mysteryven@gmail.com>
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@keita-hino @IWANABETHATGUY
feat(linter): eslint-plugin-jest require-to-throw-message (oxc-projec…
3584bbc 
…t#2384)

partof: oxc-project#492 

docs:
https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-to-throw-message.md
code:
https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/require-to-throw-message.ts
test:
https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/__tests__/require-to-throw-message.test.ts
mysteryven added a commit that referenced this issue Jun 2, 2024
@eryue0220 @mysteryven
feat(linter): eslint-plugin-jest/no-large-snapshot (#3436)
daf559f 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/no-large-snapshots.ts)

---------

Co-authored-by: wenzhe <mysteryven@gmail.com>
@eryue0220 eryue0220 mentioned this issue Jun 8, 2024
Merged
mysteryven pushed a commit that referenced this issue Jun 11, 2024
@eryue0220
feat(linter): eslint-plugin-jest/max-nested-describes (#3585)
85c3b83 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/max-nested-describe.ts)
@eryue0220 eryue0220 mentioned this issue Jun 24, 2024
Merged
mysteryven pushed a commit that referenced this issue Jun 26, 2024
@eryue0220
feat(linter): �eslint-plugin-jest/prefer-jest-mocked (#3865)
fc48cb4 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-jest-mocked.ts)
This was referenced Jul 4, 2024
Merged
Merged
mysteryven pushed a commit that referenced this issue Jul 6, 2024
@eryue0220
feat(linter): eslint-plugin-jest/consistent-test-it (#4053)
1681b11 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/consistent-test-it.ts)
mysteryven pushed a commit that referenced this issue Jul 10, 2024
@eryue0220
feat(linter): eslint-plugin-jest/prefer-hooks-in-order (#4052)
2188144 
part of #492

Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-hooks-in-order.ts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mysteryven mysteryven

Labels
A-linter Area - Linter good first issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Boshen @keita-hino @mysteryven