Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): JSX set symbol_id on imports #3523

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jun 3, 2024

JSX transform set symbol_id on imported bindings. e.g. _jsx in import {jsx as _jsx} from "react/jsx-runtime";.

Setting matching reference_id on IdentifierReferences referring to the imports is not yet implemented.

Copy link

graphite-app bot commented Jun 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #3523 will not alter performance

Comparing 06-03-fix_transformer_jsx_set_symbol_id_on_imports (591c54b) with main (837776e)

Summary

✅ 22 untouched benchmarks

Copy link

graphite-app bot commented Jun 4, 2024

Merge activity

JSX transform set `symbol_id` on imported bindings. e.g. `_jsx` in `import {jsx as _jsx} from "react/jsx-runtime";`.

Setting matching `reference_id` on `IdentifierReference`s referring to the imports is not yet implemented.
@Boshen Boshen force-pushed the 06-03-perf_transformer_react_jsx_reduce_allocations branch from d6d50d4 to 91519d9 Compare June 4, 2024 03:04
@Boshen Boshen force-pushed the 06-03-fix_transformer_jsx_set_symbol_id_on_imports branch from ec0eb58 to 591c54b Compare June 4, 2024 03:04
@Boshen Boshen changed the base branch from 06-03-perf_transformer_react_jsx_reduce_allocations to main June 4, 2024 03:09
@graphite-app graphite-app bot merged commit 591c54b into main Jun 4, 2024
22 checks passed
@graphite-app graphite-app bot deleted the 06-03-fix_transformer_jsx_set_symbol_id_on_imports branch June 4, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant