fix(transformer): JSX set reference_id on refs to imports

[overlookmotel]

Set reference_id for references to new imported bindings. e.g. _jsx in _jsx(Foo, {}) where JSX transform has inserted import {jsx as _jsx} from "react/jsx-runtime";.

[overlookmotel]

• fix(transformer): JSX set reference_id on refs to imports #3524 👈
• fix(transformer): JSX set symbol_id on imports #3523
• perf(transformer): React JSX reduce allocations #3522
• perf(transformer): React JSX reuse same Atoms #3521
• refactor(traverse): generate_uid return SymbolId #3520
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #3524 will not alter performance

_{Comparing 06-03-fix_transformer_jsx_set_reference_id_on_refs_to_imports (cacb11f) with main (9fe0863)}

Summary

✅ 22 untouched benchmarks

[overlookmotel]

@Dunqing I was hoping this would fix some of the failing tests you mentioned last week where imports get removed on a 2nd pass through transformer. But it doesn't, so my code may be wrong.

Can you remind me of such a case? I think it was something like:

const component = <Foo />;
type X = React;

[overlookmotel]

@Dunqing I was hoping this would fix some of the failing tests you mentioned last week where imports get removed on a 2nd pass through transformer. But it doesn't, so my code may be wrong.

We discussed. The test case I was thinking of is not relevant to React JSX transform.