Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): print some missing typescript attributes #3980

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jun 30, 2024

No description provided.

Copy link

graphite-app bot commented Jun 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Jun 30, 2024
Copy link
Member Author

Boshen commented Jun 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Jun 30, 2024

Merge activity

@Boshen Boshen force-pushed the 06-30-fix_codegen_print_some_missing_typescript_attributes branch from cda89c9 to dac617d Compare June 30, 2024 08:58
@graphite-app graphite-app bot merged commit dac617d into main Jun 30, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 06-30-fix_codegen_print_some_missing_typescript_attributes branch June 30, 2024 09:01
Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #3980 will not alter performance

Comparing 06-30-fix_codegen_print_some_missing_typescript_attributes (dac617d) with main (dc6d45e)

Summary

✅ 28 untouched benchmarks

@github-actions github-actions bot mentioned this pull request Jun 30, 2024
Boshen added a commit that referenced this pull request Jun 30, 2024
## [0.16.2] - 2024-06-30

### Features

- dc6d45e ast,codegen: Add `TSParenthesizedType` and print type
parentheses correctly (#3979) (Boshen)
- 63f36da parser: Parse modifiers with `parse_modifiers` (take 2)
(#3977) (DonIsaac)

### Bug Fixes

- dac617d codegen: Print some missing typescript attributes (#3980)
(Boshen)
- bd1141d isolated-declarations: If declarations is referenced in
`declare global` then keep it (#3982) (Dunqing)

### Performance

- b234ddd semantic: Only check for jsdoc if jsdoc building is enabled
(Boshen)
- 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac)
- 0c81fbe syntax: Use `NonZeroU32` for `SymbolId` and `ReferenceId`
(#3970) (Boshen)

### Refactor

- 5845057 transformer: Pass in symbols and scopes (#3978) (Boshen)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant