fix(isolated-declarations): if declarations is referenced in declare global then keep it
#3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
declare global then keep it
CodSpeed Performance ReportMerging #3982 will not alter performanceComparing Summary
|
|
Seems merging in Graphite cannot auto close linked issues? Can you check it? @Boshen |
Merge activity
|
Boshen
force-pushed
the
06-30-fix_isolated-declarations_if_declarations_is_referenced_in_declare_global_then_keep_it
branch
from
5f4adc6
to
bd1141d
Compare
graphite-app
bot
deleted the
06-30-fix_isolated-declarations_if_declarations_is_referenced_in_declare_global_then_keep_it
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jun 30, 2024
## [0.16.2] - 2024-06-30 ### Features - dc6d45e ast,codegen: Add `TSParenthesizedType` and print type parentheses correctly (#3979) (Boshen) - 63f36da parser: Parse modifiers with `parse_modifiers` (take 2) (#3977) (DonIsaac) ### Bug Fixes - dac617d codegen: Print some missing typescript attributes (#3980) (Boshen) - bd1141d isolated-declarations: If declarations is referenced in `declare global` then keep it (#3982) (Dunqing) ### Performance - b234ddd semantic: Only check for jsdoc if jsdoc building is enabled (Boshen) - 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac) - 0c81fbe syntax: Use `NonZeroU32` for `SymbolId` and `ReferenceId` (#3970) (Boshen) ### Refactor - 5845057 transformer: Pass in symbols and scopes (#3978) (Boshen) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #3981