fix(isolated_declarations): Infer type of template literal expressions as string

[MichaelMitchell-at]

In a "non-const" context, a template literal string can just be inferred a string. This is consistent with TypeScript's behavior.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #4068 will not alter performance

_{Comparing MichaelMitchell-at:07-06-fix_isolated_declarations_infer_type_of_template_literal_expressions_as_string (4d52708) with main (51d56d3)}

Summary

✅ 28 untouched benchmarks

[Dunqing]

The infer_type_from_expression method can infer TemplateLiteral as a string. But there is a mistake here, when expression exists but can be inferred, we should infer that it is a string type

oxc/crates/oxc_isolated_declarations/src/inferrer.rs

Lines 28 to 34 in adee728

	Expression::TemplateLiteral(lit) => {
	if lit.expressions.is_empty() {
	Some(self.ast.ts_string_keyword(SPAN))
	} else {
	None
	}
	}

oxc/crates/oxc_isolated_declarations/src/inferrer.rs

Line 155 in adee728

Expression::TemplateLiteral(lit) => !lit.expressions.is_empty(),

[MichaelMitchell-at]

@Dunqing I've updated the logic. Please have another look.