Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isolated-declarations): keep literal value for readonly property #4106

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 8, 2024

close: #4036

Copy link

graphite-app bot commented Jul 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Jul 8, 2024

@github-actions github-actions bot added the A-isolated-declarations Isolated Declarations label Jul 8, 2024
@Dunqing Dunqing marked this pull request as ready for review July 8, 2024 06:02
@Dunqing Dunqing changed the title fix(isolated-declarations): keep static value for readonly property fix(isolated-declarations): keep literal value for readonly property Jul 8, 2024
Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #4106 will not alter performance

Comparing 07-08-fix_isolated-declarations_keep_static_value_for_readonly_property (5c31236) with main (0f02608)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 8, 2024
Copy link

graphite-app bot commented Jul 8, 2024

Merge activity

  • Jul 8, 2:50 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 8, 2:50 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 8, 2:57 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-08-fix_isolated-declarations_do_not_infer_type_for_private_parameters branch from ab748ea to e67c7d1 Compare July 8, 2024 06:51
@Boshen Boshen force-pushed the 07-08-fix_isolated-declarations_keep_static_value_for_readonly_property branch from bf2c170 to 5c31236 Compare July 8, 2024 06:52
@Boshen Boshen changed the base branch from 07-08-fix_isolated-declarations_do_not_infer_type_for_private_parameters to main July 8, 2024 06:55
@graphite-app graphite-app bot merged commit 5c31236 into main Jul 8, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-08-fix_isolated-declarations_keep_static_value_for_readonly_property branch July 8, 2024 06:57
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Boshen added a commit that referenced this pull request Jul 8, 2024
## [0.17.2] - 2024-07-08

### Features

- 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088)
(rzvxa)
- 720983a napi/transform: Allow setting `sourceType` to `transform`
(#4113) (Boshen)
- e386b62 semantic: Check for invalid type import assignments (#4097)
(DonIsaac)

### Bug Fixes

- 5472b7c codegen: 256 indentations level is not enough for codegen
(Boshen)
- 5c31236 isolated-declarations: Keep literal value for readonly
property (#4106) (Dunqing)
- e67c7d1 isolated-declarations: Do not infer type for private
parameters (#4105) (Dunqing)
- 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from
inside parameters (#4077) (michaelm)
- f8d77e4 isolated_declarations: Infer type of template literal
expressions as string (#4068) (michaelm)
- 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don
Isaac)
- 4413e2d transformer: Missing initializer for readonly consructor
properties (#4103) (Don Isaac)

### Performance

- 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to
speed up the `contain` (#4074) (Dunqing)
- 9114c8e semantic: Keep a single map of unresolved references (#4107)
(Luca Bruno)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-isolated-declarations Isolated Declarations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolated declarations: if class property type is inferred to literal, it should remain a value
2 participants