-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): strongly-typed rule schemas #4151
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #4151 will degrade performances by 98.34%Comparing Summary
Benchmarks breakdown
|
…y' of github.com:oxc-project/oxc into don/07-09-feat_linter_better_schemas_for_allow/warn/deny
…ithub.com:oxc-project/oxc into don/07-09-feat_linter_strongly-typed_rule_schemas
0387c40
to
cc58614
Compare
Just a small performance regression 😆 I'll fix that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge and seems pointless to snapshot anymore because every rule change will change this file 😅 We can read the json and test its content instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reason. We need to stop committing this file and generate on demand instead.
Concerning the perf regression, I think it's just that this branch is out of date with main. I think you'll find if you rebase on latest main, it'll disappear. |
@overlookmotel I've entered rebase purgatory on this branch, I'll create a new one and re-open this PR. |
Re-created in #4174 |
Part of #4146
feat(linter): strongly-typed rule schemas
feat(macros): schema parsing for declare_oxc_lint macro
Screenshots