Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): strongly-typed rule schemas #4151

Closed

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jul 10, 2024

Part of #4146

feat(linter): strongly-typed rule schemas
feat(macros): schema parsing for declare_oxc_lint macro

Screenshots

image

Copy link

graphite-app bot commented Jul 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

DonIsaac commented Jul 10, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #4151 will degrade performances by 98.34%

Comparing don/07-09-feat_linter_strongly-typed_rule_schemas (521b219) with main (48947a2)

Summary

❌ 4 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main don/07-09-feat_linter_strongly-typed_rule_schemas Change
semantic[antd.js] 212.8 ms 12,830.6 ms -98.34%
semantic[cal.com.tsx] 66.9 ms 139 ms -51.89%
semantic[checker.ts] 136.5 ms 2,686.2 ms -94.92%
semantic[pdf.mjs] 33.5 ms 90.9 ms -63.1%

@DonIsaac DonIsaac force-pushed the don/07-09-feat_linter_better_schemas_for_allow/warn/deny branch from 0387c40 to cc58614 Compare July 10, 2024 02:51
@DonIsaac DonIsaac changed the base branch from don/07-09-feat_linter_better_schemas_for_allow/warn/deny to main July 10, 2024 02:55
@DonIsaac
Copy link
Contributor Author

Just a small performance regression 😆 I'll fix that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge and seems pointless to snapshot anymore because every rule change will change this file 😅 We can read the json and test its content instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason. We need to stop committing this file and generate on demand instead.

@overlookmotel
Copy link
Contributor

Concerning the perf regression, I think it's just that this branch is out of date with main. I think you'll find if you rebase on latest main, it'll disappear.

@DonIsaac
Copy link
Contributor Author

@overlookmotel I've entered rebase purgatory on this branch, I'll create a new one and re-open this PR.

@DonIsaac
Copy link
Contributor Author

Re-created in #4174

@DonIsaac DonIsaac closed this Jul 10, 2024
@Boshen Boshen deleted the don/07-09-feat_linter_strongly-typed_rule_schemas branch September 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants