-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): generate schemas for rules (with documentation) #4174
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4174 will not alter performanceComparing Summary
|
I'll take a look at this today. |
473df2e
to
334c859
Compare
Do you think it's reasonable to only generate the minimum? "comma-dangle": {
"$ref": "#/definitions/rule",
"description": "Require or disallow trailing commas"
}, |
334c859
to
b74b53a
Compare
Unfortunately, I'm not sure how to get that... rules only have documentation, not a summary. |
@Boshen what would you like to do with this PR? |
I'll allocate some time later this week to go over all the bigger linter changes. |
Shall we try and clean up the schema incrementally? It's difficult to review and merge this PR. |
Re-creation of #4151.
@Boshen I'm not sure what we want to do about
configuration_schema.json
, should we add aprepublish
task to create it withinoxlint
?