Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/typescript) shadowed imports have not been removed #4550

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 30, 2024

close: #4423

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jul 30, 2024
@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_shadowed_imports_have_not_been_removed branch from c569af1 to 7edaefb Compare July 30, 2024 16:04
Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Merging #4550 will not alter performance

Comparing 07-30-fix_transformer_typescript_shadowed_imports_have_not_been_removed (48031ad) with main (b2da22b)

Summary

✅ 32 untouched benchmarks

Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_incorrect_symbolflags_for_jsx_imports branch from 3b60b99 to 4586091 Compare July 31, 2024 05:26
@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_shadowed_imports_have_not_been_removed branch from 7edaefb to 785151a Compare July 31, 2024 05:27
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 4, 2024
Copy link

graphite-app bot commented Aug 4, 2024

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 4, 2024
@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_incorrect_symbolflags_for_jsx_imports branch from 4586091 to 1936082 Compare August 5, 2024 01:40
@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_shadowed_imports_have_not_been_removed branch from 785151a to 15b6738 Compare August 5, 2024 01:40
@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_incorrect_symbolflags_for_jsx_imports branch from 1936082 to 4efd54b Compare August 5, 2024 03:15
@Dunqing Dunqing force-pushed the 07-30-fix_transformer_typescript_shadowed_imports_have_not_been_removed branch from 15b6738 to 48031ad Compare August 5, 2024 03:15
@Dunqing Dunqing changed the base branch from 07-30-fix_transformer_typescript_incorrect_symbolflags_for_jsx_imports to main August 5, 2024 03:22
@graphite-app graphite-app bot merged commit 48031ad into main Aug 5, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-30-fix_transformer_typescript_shadowed_imports_have_not_been_removed branch August 5, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformer: non-type-only import is only referenced by the type, but is not eliminated.
2 participants