feat(transformer_conformance): test ScopeTree and SymbolTable for correctness after transformation

[Dunqing]

part of #4549

This test verifies that the correct symbols and scopes were added/changed during the transformation. From the snapshots, most of them are incorrect currently

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• fix(transformer/typescript) shadowed imports have not been removed #4550
• fix(transformer/typescript): incorrect SymbolFlags for jsx imports #4549
• feat(transformer_conformance): test ScopeTree and SymbolTable for correctness after transformation #4581 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4581 will not alter performance

_{Comparing 07-31-feat_transformer_conformance_test_scopetree_and_symboltable_after_transformation (3a6e4d9) with main (c69ada4)}

Summary

✅ 32 untouched benchmarks

[DonIsaac]

Also related: #4454

[overlookmotel]

Great to have the beginnings of test infra for this.

I'm not surprised that TS tests are failing because I didn't complete the work of setting scopes correctly in those transforms, but I would have hoped more of the React/JSX ones would pass.

@Dunqing are you working on fixing, or shall I?

[Dunqing]

@Dunqing are you working on fixing, or shall I?

Yes, I am working on this! Should we merge this first? and then fix failed tests in follow-up PRs?

[graphite-app]

Merge activity

• Aug 4, 7:44 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Aug 4, 7:48 AM EDT: Boshen merged this pull request with the Graphite merge queue.

[overlookmotel]

@Dunqing OK great. Please can you ping me if/when you get to the JSX ones? I thought I'd got them at least mostly right, so I'd be interested to know where I went wrong.