refactor(ast, ast_codegen): CloneIn implementations now initialize semantic related cells with Default value.
#4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rzvxa
changed the title
CloneIn implementations now set SymbolId, ScopeId, ReferenceId and ReferenceFlag NoneCloneIn implementations now initialize semantic related cells with Default value.
CodSpeed Performance ReportMerging #4819 will not alter performanceComparing Summary
|
DonIsaac
changed the title
CloneIn implementations now initialize semantic related cells with Default value.CloneIn implementations now initialize semantic related cells with Default value.
overlookmotel
approved these changes
Aug 11, 2024
Merge activity
|
overlookmotel
changed the base branch from
08-10-refactor_ast_codegen_simplify_innermarkers_
to
graphite-base/4819
overlookmotel
force-pushed
the
08-11-refacotr_ast_ast_codegen_clonein_implementations_now_set_symbolid_scopeid_referenceid_and_referenceflag_none_
branch
from
de91581 to
11e6f5d
Compare
overlookmotel
force-pushed
the
graphite-base/4819
branch
from
8c357ed to
74af8e2
Compare
overlookmotel
added
0-merge
overlookmotel
force-pushed
the
08-11-refacotr_ast_ast_codegen_clonein_implementations_now_set_symbolid_scopeid_referenceid_and_referenceflag_none_
branch
from
11e6f5d to
0ea697b
Compare
graphite-app
bot
deleted the
08-11-refacotr_ast_ast_codegen_clonein_implementations_now_set_symbolid_scopeid_referenceid_and_referenceflag_none_
branch
overlookmotel
added a commit
that referenced
this pull request
Aug 11, 2024
Follow-on after #4819. Style nit. Add a line break after `#![allow(...)]`.
Merged
Boshen
added a commit
that referenced
this pull request
Aug 12, 2024
## [0.24.2] - 2024-08-12 ### Features - 8e10e25 allocator: Introduce `Address` (#4810) (overlookmotel) ### Bug Fixes - 62f759c transformer/typescript: Generated assignment for constructor arguments with access modifiers should be injected to the top of the constructor (#4808) (Dunqing) ### Performance - 504ac0b minifier: `InjectGlobalVariables` only add to `replaced_dot_defines` once for each (#4803) (overlookmotel) - 35f2742 minifier: Avoid repeated `Atom` creation in `InjectGlobalVariables` (#4802) (overlookmotel) ### Documentation - 8827659 ast: More doc comments for JSX nodes (#4830) (DonIsaac) - 559baa5 parser: Clean up doc regarding performance; remove conformance (Boshen) ### Refactor - 0ea697b ast, ast_codegen: `CloneIn` implementations now initialize semantic related cells with `Default` value. (#4819) (rzvxa) - ecfa124 ast_codegen: Add line break to generated code (#4829) (overlookmotel) - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4809