Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ast): more doc comments for JSX nodes #4830

Merged

Conversation

DonIsaac
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Aug 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

DonIsaac commented Aug 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-ast Area - AST label Aug 11, 2024
@DonIsaac DonIsaac marked this pull request as ready for review August 11, 2024 21:27
Copy link

codspeed-hq bot commented Aug 11, 2024

CodSpeed Performance Report

Merging #4830 will not alter performance

Comparing don/08-11-docs_ast_more_doc_comments_for_jsx_nodes (8827659) with main (ecfa124)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/08-11-docs_ast_more_doc_comments_for_jsx_nodes branch from 9c855bc to b3ca7ee Compare August 11, 2024 21:45
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 12, 2024 — with Graphite App
Copy link

graphite-app bot commented Aug 12, 2024

Merge activity

@Boshen Boshen force-pushed the don/08-11-docs_ast_more_doc_comments_for_jsx_nodes branch from b3ca7ee to 8827659 Compare August 12, 2024 01:11
@graphite-app graphite-app bot merged commit 8827659 into main Aug 12, 2024
24 checks passed
@graphite-app graphite-app bot deleted the don/08-11-docs_ast_more_doc_comments_for_jsx_nodes branch August 12, 2024 01:14
@oxc-bot oxc-bot mentioned this pull request Aug 12, 2024
Boshen added a commit that referenced this pull request Aug 12, 2024
## [0.24.2] - 2024-08-12

### Features

- 8e10e25 allocator: Introduce `Address` (#4810) (overlookmotel)

### Bug Fixes

- 62f759c transformer/typescript: Generated assignment for constructor
arguments with access modifiers should be injected to the top of the
constructor (#4808) (Dunqing)

### Performance

- 504ac0b minifier: `InjectGlobalVariables` only add to
`replaced_dot_defines` once for each (#4803) (overlookmotel)
- 35f2742 minifier: Avoid repeated `Atom` creation in
`InjectGlobalVariables` (#4802) (overlookmotel)

### Documentation

- 8827659 ast: More doc comments for JSX nodes (#4830) (DonIsaac)
- 559baa5 parser: Clean up doc regarding performance; remove conformance
(Boshen)

### Refactor

- 0ea697b ast, ast_codegen: `CloneIn` implementations now initialize
semantic related cells with `Default` value. (#4819) (rzvxa)
- ecfa124 ast_codegen: Add line break to generated code (#4829)
(overlookmotel)
- 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants