refactor(transformer): break up RegExp transform into multiple functions

[overlookmotel]

Experiment. Idea is to split up the transform, with the heavy logic in separate functions, so potentially the compiler can inline the smaller "entry" functions.

enter_expression is now tiny, and transform_regexp also quite short as it's all simple comparisons. transform_regexp contains all the logic for bailing out quickly, so potentially the fast path for doing nothing could all get inlined.

[overlookmotel]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• refactor(transformer): break up RegExp transform into multiple functions #5511 👈
• fix(transformer): RegExp transform only set span on final expression #5508 : 1 other dependent PR (#5527 )
• refactor(transformer): RegExp transform unbox early #5504
• fix(transformer): RegExp transform handle Term::Quantifier #5501
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #5511 will not alter performance

_{Comparing 09-05-refactor_transformer_break_up_regexp_transform_into_multiple_functions (d2829e3) with 09-05-fix_transformer_regexp_transform_only_set_span_on_final_expression (d1c9770)}

Summary

✅ 29 untouched benchmarks

[overlookmotel]

Well that doesn't work!

[overlookmotel]

My more minimal version which only moves all the logic into a separate function from enter_expression also does not produce any notable benchmark gain.

A failed experiment!