Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer): add trailing line breaks to conformance fixtures #5537

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Sep 6, 2024

Currently whether conformance fixture files have trailing line breaks is inconsistent - some have them, some don't. Make all of them have a trailing line break.

Copy link

graphite-app bot commented Sep 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 6, 2024
@overlookmotel overlookmotel marked this pull request as ready for review September 6, 2024 10:44
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 6, 2024
Copy link

graphite-app bot commented Sep 6, 2024

Merge activity

  • Sep 6, 7:52 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 6, 7:52 AM EDT: Dunqing added this pull request to the Graphite merge queue.
  • Sep 6, 8:18 AM EDT: Dunqing merged this pull request with the Graphite merge queue.

…5537)

Currently whether conformance fixture files have trailing line breaks is inconsistent - some have them, some don't. Make all of them have a trailing line break.
@Dunqing Dunqing force-pushed the 09-06-test_transformer_move_regexp_transform_conformance_tests branch from 71b2f2b to e18c2ed Compare September 6, 2024 12:04
@Dunqing Dunqing force-pushed the 09-06-test_transformer_add_trailing_line_breaks_to_conformance_fixtures branch from 2ed8685 to 87a79d9 Compare September 6, 2024 12:05
Base automatically changed from 09-06-test_transformer_move_regexp_transform_conformance_tests to main September 6, 2024 12:16
@graphite-app graphite-app bot merged commit 87a79d9 into main Sep 6, 2024
16 checks passed
@graphite-app graphite-app bot deleted the 09-06-test_transformer_add_trailing_line_breaks_to_conformance_fixtures branch September 6, 2024 12:18
overlookmotel added a commit that referenced this pull request Sep 6, 2024
Continuation of #5537. Ensure all conformance fixture files have a trailing line break.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants