refactor(semantic): move Counts code into counter module
#5710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Sep 11, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #5710 will not alter performanceComparing Summary
|
This was referenced Sep 11, 2024
Merge activity
|
Pure refactor. Move code for counting nodes etc, and verifying counts, into `counter` module.
DonIsaac
force-pushed
the
09-11-refactor_semantic_rename_counts_in_transform_checker
branch
from
8f438db
to
339fcfc
Compare
DonIsaac
force-pushed
the
09-11-refactor_semantic_move_counts_code_into_counter_module
branch
from
1b4412f
to
ac6203c
Compare
Base automatically changed from
09-11-refactor_semantic_rename_counts_in_transform_checker
to
main
September 11, 2024 20:45
graphite-app
bot
deleted the
09-11-refactor_semantic_move_counts_code_into_counter_module
branch
Boshen
reviewed
Sep 12, 2024
| @@ -30,6 +30,7 @@ oxc_syntax = { workspace = true } | |||
| assert-unchecked = { workspace = true } | |||
| indexmap = { workspace = true } | |||
| itertools = { workspace = true } | |||
| more-asserts = { workspace = true } | |||
There was a problem hiding this comment.
FYI this is slightly against our policy of minimal third-party crates. https://oxc.rs/docs/contribute/rules.html#development-policy
Boshen
reviewed
Sep 12, 2024
| // This is not a big problem - allocating a `Vec` with excess capacity is cheap. | ||
| // It's allocating with *not enough* capacity which is costly, as then the `Vec` | ||
| // will grow and reallocate. | ||
| assert_le!(actual.symbols, estimated.symbols, "symbols count mismatch"); |
There was a problem hiding this comment.
This can be written as assert!(actual.symbols < estimated.symbols, "{} < {}", actual.symbols, estimated.symbols)
Boshen
pushed a commit
that referenced
this pull request
Sep 13, 2024
Remove `more-asserts` dependency which was added in #5710. As suggested by @Boshen in #5710 (review).
Boshen
added a commit
that referenced
this pull request
Sep 13, 2024
## [0.29.0] - 2024-09-13 - 71116a1 index: [**BREAKING**] Remove ability to index `IndexVec` with `usize` (#5733) (overlookmotel) - c3dd2a0 ast: [**BREAKING**] Revert: reduce byte size of `TaggedTemplateExpression::quasi` by `Boxing` it (#5679) (#5715) (overlookmotel) ### Features - 953fe17 ast: Provide `NONE` type for AST builder calls (#5737) (overlookmotel) - a362f51 index: Add `IndexVec::shrink_to` (#5713) (overlookmotel) - e968e9f minifier: Constant fold nullish coalescing operator (#5761) (Boshen) - 6bc13f6 minifier: Add `MinimizeConditions` pass (#5747) (Boshen) - 805fbac oxc_cfg: Better control flow graph dot dot repr (#5731) (IWANABETHATGUY) - f3baa49 semantic: Add `SemanticBuilder::with_stats` (#5757) (overlookmotel) - 7fa0cb3 semantic: Expose `Stats` (#5755) (overlookmotel) ### Bug Fixes - 8ff013a minifier: Handle dce CallExpression::callee (#5752) (Boshen) - 608b7d3 napi/transformer: Refresh plugin doesn't work even after passing the refresh option (#5702) (Dunqing) - 042afa9 syntax: Correctly check for valid `RedeclarationId`s (#5759) (overlookmotel) - 77d9170 transformer/react: IsStaticChildren should be false when there is only one child (#5745) (Dunqing) ### Performance - 333e2e0 index: Remove `Idx` bounds-checks from `first` + `last` methods (#5726) (overlookmotel) - d18c896 rust: Use `cow_utils` instead (#5664) (dalaoshu) ### Refactor - 2890c98 minifier: Add tests for `remove_syntax` (#5749) (Boshen) - 9a9d8f6 minifier: Replace `self.ast` with `ctx.ast` (#5748) (Boshen) - 746f7b3 minifier: Align code with closure compiler (#5717) (Boshen) - 21e2df5 minifier: Replace `VisitMut` with `Traverse` for inject and define plugins (#5705) (Boshen) - 4bdc202 rust: Remove some #[allow(unused)] (#5716) (Boshen) - a35fb14 semantic: `Stats::assert_accurate` take `self` (#5758) (overlookmotel) - 4b896f1 semantic: Make `Stats` `Copy` (#5756) (overlookmotel) - b4b460f semantic: `Stats` store counts as `u32` (#5754) (overlookmotel) - 667170c semantic: Rename `Counts` to `Stats` (#5753) (overlookmotel) - cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen) - 7dfcdfc semantic: Remove `more-asserts` dependency (#5739) (overlookmotel) - 6436524 semantic: Fix dead code warning in release mode (#5728) (overlookmotel) - e02621d semantic: Re-order use statements (#5712) (overlookmotel) - ac6203c semantic: Move `Counts` code into counter module (#5710) (overlookmotel) - 339fcfc semantic: Rename `Counts` in transform checker (#5709) (overlookmotel) - d8ec781 semantic: Remove `record_ast_node` call for `Program` (#5701) (overlookmotel) ### Styling - 1857ff0 semantic: Rename vars for node IDs (#5699) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Move code for counting nodes etc, and verifying counts, into
countermodule.