Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oxc_cfg): better control flow graph dot dot repr #5731

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat(oxc_cfg): better control flow graph dot dot repr #5731

merged 1 commit into from
Sep 12, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Sep 12, 2024 •
edited
Loading

  1. add basic block index for each basicblock, so there should no basic block display empty string
  2. use shape box, since it is basic block

Before

image

After

image

@github-actions github-actions bot added the A-semantic Area - Semantic label Sep 12, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat(oxc_cfg): better control flow graph dot repr feat(oxc_cfg): better control flow graph dot dot repr Sep 12, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5731 will not alter performance

Comparing feat/better-debug-dot (805fbac) with main (d8b612c)

Summary

✅ 29 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 12, 2024 16:38
rzvxa
rzvxa approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@rzvxa rzvxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice😍

@rzvxa
Copy link
Collaborator

rzvxa commented Sep 12, 2024

On another kind of related note; It will be super cool if we add 2 checkboxes to the playground for adding some extra information to the graph and show/hide implicit error paths.

I sometimes use this example to get extra debug information while I'm tracking something. It's a bit noisy but it has helped me quite a few times and might be useful to others as well.

https://github.com/oxc-project/oxc/blob/main/crates/oxc_semantic/examples/cfg.rs

@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Sep 12, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 12, 2024 •
edited
Loading

Merge activity

  • Sep 12, 2:38 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 12, 2:38 PM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Sep 12, 2:42 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

@IWANABETHATGUY
feat(oxc_cfg): better control flow graph dot dot repr (#5731)
805fbac 
1. add basic block index for each basicblock, so there should no basic block display empty string
2. use `shape` box, since it is basic **block**
## Before
![image](https://github.com/user-attachments/assets/9b556cca-8401-40bd-b3b6-d31c5e7cf8ba)

## After
![image](https://github.com/user-attachments/assets/b8e4c52d-ecdf-4e92-85be-ea37f0cb2330)
@graphite-app graphite-app bot merged commit 805fbac into main Sep 12, 2024
26 checks passed
@graphite-app graphite-app bot deleted the feat/better-debug-dot branch September 12, 2024 18:42
@IWANABETHATGUY
Copy link
Contributor Author

On another kind of related note; It will be super cool if we add 2 checkboxes to the playground for adding some extra information to the graph and show/hide implicit error paths.

I sometimes use this example to get extra debug information while I'm tracking something. It's a bit noisy but it has helped me quite a few times and might be useful to others as well.

https://github.com/oxc-project/oxc/blob/main/crates/oxc_semantic/examples/cfg.rs

Sure, I will have a look.

@oxc-bot oxc-bot mentioned this pull request Sep 13, 2024
Merged
Boshen added a commit that referenced this pull request Sep 13, 2024
@oxc-bot @Boshen
release(crates): v0.29.0 (#5763)
bd48dfb 
## [0.29.0] - 2024-09-13

- 71116a1 index: [**BREAKING**] Remove ability to index `IndexVec` with
`usize` (#5733) (overlookmotel)

- c3dd2a0 ast: [**BREAKING**] Revert: reduce byte size of
`TaggedTemplateExpression::quasi` by `Boxing` it (#5679) (#5715)
(overlookmotel)

### Features

- 953fe17 ast: Provide `NONE` type for AST builder calls (#5737)
(overlookmotel)
- a362f51 index: Add `IndexVec::shrink_to` (#5713) (overlookmotel)
- e968e9f minifier: Constant fold nullish coalescing operator (#5761)
(Boshen)
- 6bc13f6 minifier: Add `MinimizeConditions` pass (#5747) (Boshen)
- 805fbac oxc_cfg: Better control flow graph dot dot repr (#5731)
(IWANABETHATGUY)
- f3baa49 semantic: Add `SemanticBuilder::with_stats` (#5757)
(overlookmotel)
- 7fa0cb3 semantic: Expose `Stats` (#5755) (overlookmotel)

### Bug Fixes

- 8ff013a minifier: Handle dce CallExpression::callee (#5752) (Boshen)
- 608b7d3 napi/transformer: Refresh plugin doesn't work even after
passing the refresh option (#5702) (Dunqing)
- 042afa9 syntax: Correctly check for valid `RedeclarationId`s (#5759)
(overlookmotel)
- 77d9170 transformer/react: IsStaticChildren should be false when there
is only one child (#5745) (Dunqing)

### Performance

- 333e2e0 index: Remove `Idx` bounds-checks from `first` + `last`
methods (#5726) (overlookmotel)
- d18c896 rust: Use `cow_utils` instead (#5664) (dalaoshu)

### Refactor

- 2890c98 minifier: Add tests for `remove_syntax` (#5749) (Boshen)
- 9a9d8f6 minifier: Replace `self.ast` with `ctx.ast` (#5748) (Boshen)
- 746f7b3 minifier: Align code with closure compiler (#5717) (Boshen)
- 21e2df5 minifier: Replace `VisitMut` with `Traverse` for inject and
define plugins (#5705) (Boshen)
- 4bdc202 rust: Remove some #[allow(unused)] (#5716) (Boshen)
- a35fb14 semantic: `Stats::assert_accurate` take `self` (#5758)
(overlookmotel)
- 4b896f1 semantic: Make `Stats` `Copy` (#5756) (overlookmotel)
- b4b460f semantic: `Stats` store counts as `u32` (#5754)
(overlookmotel)
- 667170c semantic: Rename `Counts` to `Stats` (#5753) (overlookmotel)
- cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen)
- 7dfcdfc semantic: Remove `more-asserts` dependency (#5739)
(overlookmotel)
- 6436524 semantic: Fix dead code warning in release mode (#5728)
(overlookmotel)
- e02621d semantic: Re-order use statements (#5712) (overlookmotel)
- ac6203c semantic: Move `Counts` code into counter module (#5710)
(overlookmotel)
- 339fcfc semantic: Rename `Counts` in transform checker (#5709)
(overlookmotel)
- d8ec781 semantic: Remove `record_ast_node` call for `Program` (#5701)
(overlookmotel)

### Styling

- 1857ff0 semantic: Rename vars for node IDs (#5699) (overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzvxa rzvxa rzvxa approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @rzvxa