refactor(transformer/async-to-generator): move handling of MethodDefinition's value to exit_function
#7105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7105 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Nov 4, 2024
Merge activity
|
…inition`'s value to `exit_function` (#7105) Part of #7074 We need to handle this before the `arrow_function` plugin inserts `_this = this` because, in the `async-to-generator` plugin, we will move the body to an inner generator function. However, we don't want `_this = this` moved to the inner generator function as well. So as long as we move first, and then insert, we can fix this problem. The new semantic error is related to another tricky problem, I will fix it in another PR
overlookmotel
force-pushed
the
11-04-refactor_transformer_async-to-generator_move_handling_of_methoddefinition_s_value_to_exit_function
branch
from
ba0eb32
to
f80085c
Compare
graphite-app
bot
deleted the
11-04-refactor_transformer_async-to-generator_move_handling_of_methoddefinition_s_value_to_exit_function
branch
Dunqing
pushed a commit
that referenced
this pull request
Nov 4, 2024
…s method (#7117) Follow-on after #7105. Correctly identify when a function is a method definition. `ctx.parent().is_method_definition()` would return `true` for this weird case where the function is the property key of the method, not the method itself: ```js class C { [async function() {}]() {} } ``` `matches!(ctx.parent(), Ancestor::MethodDefinitionValue(_))` only returns `true` if the function *is* a method definition. Of course, no-one would write such ridiculous code, but we may as well handle whatever is thrown at us. It's also slightly more performant to check for one specific ancestor type, rather than: https://github.com/oxc-project/oxc/blob/c2802e63fc0a43a7be3a4caf30d179db9eca6e5e/crates/oxc_traverse/src/generated/ancestor.rs#L1319-L1326
no-yan
pushed a commit
to no-yan/oxc
that referenced
this pull request
Nov 5, 2024
…s method (oxc-project#7117) Follow-on after oxc-project#7105. Correctly identify when a function is a method definition. `ctx.parent().is_method_definition()` would return `true` for this weird case where the function is the property key of the method, not the method itself: ```js class C { [async function() {}]() {} } ``` `matches!(ctx.parent(), Ancestor::MethodDefinitionValue(_))` only returns `true` if the function *is* a method definition. Of course, no-one would write such ridiculous code, but we may as well handle whatever is thrown at us. It's also slightly more performant to check for one specific ancestor type, rather than: https://github.com/oxc-project/oxc/blob/c2802e63fc0a43a7be3a4caf30d179db9eca6e5e/crates/oxc_traverse/src/generated/ancestor.rs#L1319-L1326
no-yan
pushed a commit
to no-yan/oxc
that referenced
this pull request
Nov 5, 2024
…thodDefinition`'s value to `exit_function` (oxc-project#7106) Part of oxc-project#7074 I have mentioned the reason why I need to move this in oxc-project#7105
Boshen
added a commit
that referenced
this pull request
Nov 9, 2024
## [0.36.0] - 2024-11-09 - b11ed2c ast: [**BREAKING**] Remove useless `ObjectProperty::init` field (#7220) (Boshen) - 0e4adc1 ast: [**BREAKING**] Remove invalid expressions from `TSEnumMemberName` (#7219) (Boshen) - 846711c transformer: [**BREAKING**] Change API to take a `&TransformOptions` instead of `TransformOptions` (#7213) (Boshen) - 092de67 types: [**BREAKING**] Append `rest` field into `elements` for objects and arrays to align with estree (#7212) (ottomated) - d1d1874 ast: [**BREAKING**] Change `comment.span` to real position that contain `//` and `/*` (#7154) (Boshen) - 843bce4 ast: [**BREAKING**] `IdentifierReference::reference_id` return `ReferenceId` (#7126) (overlookmotel) ### Features - cc8a191 ast: Methods on AST nodes to get `scope_id` etc (#7127) (overlookmotel) - dc0215c ast_tools: Add #[estree(append_to)], remove some custom serialization code (#7149) (ottomated) - 9d6cc9d estree: ESTree compatibility for all literals (#7152) (ottomated) - b74686c isolated-declarations: Support transform TSExportAssignment declaration (#7204) (Dunqing) - ad3a2f5 tasks/compat_data: Generate our own compat table (#7176) (Boshen) - b4258ee transformer: Add defaulted `Module::Preserve` option (#7225) (Boshen) - 324c3fe transformer: Add `TransformOptions::module` option (#7188) (Boshen) - a166a4a transformer: Add esbuild comma separated target API `--target=es2020,chrome58` (#7210) (Boshen) - 3a20b90 transformer: Add es target to `engineTargets` (#7193) (Boshen) - 22898c8 transformer: Warn BigInt when targeting < ES2020 (#7184) (Boshen) - a579011 transformer: Add features `ES2018NamedCapturingGroupsRegex` and `ES2018LookbehindRegex` (#7182) (Boshen) - 8573f79 transformer: Turn on async_to_generator and async_generator_functions plugins in enable_all (#7135) (Dunqing) - df77241 transformer: Enable `ArrowFunctionConverter` in `async-to-generator` and `async-generator-functions` plugins (#7113) (Dunqing) - b6a5750 transformer/arrow-function-converter: Move scope to changed scope for `this_var` if scope have changed (#7125) (Dunqing) - 1910227 transformer/async-to-generator: Support inferring the function name from the ObjectPropertyValue's key (#7201) (Dunqing) - ffa8604 transformer/async-to-generator: Do not transform await expression if is not inside async function (#7138) (Dunqing) - e536d47 transformer/babel: Add support for trying to get the `Module` from `BabelPlugins` (#7218) (Dunqing) - 5cfdc05 transformer/typescript: Support transform `export =` and `import = require(...)` when module is commonjs (#7206) (Dunqing) ### Bug Fixes - c82b273 transformer/async-generator-functions: Only transform object method in exit_function (#7200) (Dunqing) - b2a888d transformer/async-generator-functions: Incorrect transformation for `for await` if it's not placed in a block (#7148) (Dunqing) - 19892ed transformer/async-generator-functions: Transform incorrectly for `for await` if it's in LabeledStatement (#7147) (Dunqing) - ede10dc transformer/async-to-generator: Incorrect transform when super expression is inside async method (#7171) (Dunqing) - 293d072 transformer/async-to-generator: Only transform object method in exit_function (#7199) (Dunqing) - ae692d7 transformer/async_to_generator: Fix checking if function is class method (#7117) (overlookmotel) - eea4ab8 transformer/helper-loader: Incorrect `SymbolFlags` for default import when `SourceType` is script (#7226) (Dunqing) ### Refactor - d27e14f ast: `AstKind::as_*` methods take `self` (#5546) (overlookmotel) - fac5042 ast: Use `scope_id` etc methods (#7130) (overlookmotel) - a297765 minifier: Use `map` and `and_then` instead of let else (#7178) (7086cmd) - fc86703 napi/transform: Change test files to TypeScript (#7221) (Boshen) - c5485ae semantic: Add `ancestor_kinds` iterator function (#7217) (camchenry) - abf1602 semantic: Rename `iter_parents` to `ancestors` (#7216) (camchenry) - 42171eb semantic: Rename `ancestors` to `ancestor_ids` (#7215) (camchenry) - de56083 transformer: Add `impl TryFrom<EngineTargets> for EnvOptions` (#7191) (Boshen) - 0a43c64 transformer: Move `ESTarget` to its own file (#7189) (Boshen) - 0e1f12c transformer: Remove unimplemented `EnvOptions::bugfixes` (#7162) (Boshen) - a981caf transformer: Add `Engine` enum for `EngineTargets` (#7161) (Boshen) - 8340243 transformer: Rename `Query` to `BrowserslistQuery` (#7143) (Boshen) - 481f7e6 transformer: Change `Targets` to `EngineTargets` (#7142) (Boshen) - 55e6989 transformer: Deserialize engine target strings to specific keys (#7139) (Boshen) - fdfd9a4 transformer: Use `scope_id` etc methods (#7128) (overlookmotel) - ff8bd50 transformer: Move implementation of ArrowFunction to common/ArrowFunctionConverter (#7107) (Dunqing) - 4a515be transformer/arrow-function-coverter: Rename function name and add some comments to explain confusing parts. (#7203) (Dunqing) - c307e1b transformer/arrow-functions: Pass `ArenaBox` as function param (#7169) (overlookmotel) - 217d433 transformer/arrow-functions: Remove unused `&mut self` function param (#7165) (overlookmotel) - 426df71 transformer/arrow-functions: Use `scope_id` method (#7164) (overlookmotel) - 11c5e12 transformer/arrow-functions: Correct comments (#7163) (overlookmotel) - 1238506 transformer/async-generator-function: Remove inactive `#[allow(clippy::unused_self)]` attrs (#7167) (overlookmotel) - 84ee581 transformer/async-generator-functions: Simplify identifying whether within an async generator function (#7170) (overlookmotel) - 1b12328 transformer/async-generator-functions: Use `clone` not `clone_in` on `LabelIdentifier` (#7172) (overlookmotel) - cd1006f transformer/async-generator-functions: Do not transform yield expression where inside generator function (#7134) (Dunqing) - 2c5734d transformer/async-generator-functions: Do not transform await expression where inside ArrowFunctionExpression (#7132) (Dunqing) - 5ce83bd transformer/async-generator-functions: Remove dead code for handle await expression (#7131) (Dunqing) - e04ee97 transformer/async-generator-functions: Move handling of `MethodDefinition`'s value to `exit_function` (#7106) (Dunqing) - b57d5a5 transformer/async-to-generator: Remove unused `&self` function param (#7166) (overlookmotel) - f80085c transformer/async-to-generator: Move handling of `MethodDefinition`'s value to `exit_function` (#7105) (Dunqing) - e2241e6 transformer/jsx-self: Remove unused `&self` function params (#7159) (overlookmotel) - 1dfd241 transformer/optional-catch-binding: Remove inactive `#[allow(clippy::unused_self)]` attr (#7158) (overlookmotel) - fd9b44c transformer/typescript: Remove inactive `#[allow(clippy::unused_self)]` attr (#7160) (overlookmotel) - cacfb9b traverse: Use `symbol_id` etc methods (#7129) (overlookmotel) ### Styling - 38a6df6 transformer/arrow-functions: Semicolon after return statements (#7168) (overlookmotel) - 64b7e3a transformer/async-generator-functions: Import `oxc_allocator::Vec` as `ArenaVec` (#7173) (overlookmotel) ### Testing - be819dd napi/transform: Add test for not default es transform (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7074
We need to handle this before the
arrow_functionplugin inserts_this = thisbecause, in theasync-to-generatorplugin, we will move the body to an inner generator function. However, we don't want_this = thismoved to the inner generator function as well. So as long as we move first, and then insert, we can fix this problem.The new semantic error is related to another tricky problem, I will fix it in another PR