Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transformer/async-to-generator): support inferring the function name from the ObjectPropertyValue's key #7201

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat(transformer/async-to-generator): support inferring the function name from the ObjectPropertyValue's key #7201

merged 1 commit into from
Nov 8, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 8, 2024 •
edited
Loading

Support for inferring function name from ObjectPropertyValue's key

For example:

({ foo: async function() {} })

After this, we will able to infer foo for the object method

This was referenced Nov 8, 2024
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Nov 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing mentioned this pull request Nov 8, 2024
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Nov 8, 2024
@Dunqing Dunqing mentioned this pull request Nov 8, 2024
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7201 will not alter performance

Comparing 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key (1910227) with main (3a20b90)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen force-pushed the 11-08-fix_transformer_async-generator-functions_only_transform_object_method_in_exit_function branch from 729936f to adb6111 Compare November 8, 2024 02:45
@Boshen Boshen force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from 9d4633c to c50bbf1 Compare November 8, 2024 02:45
@Dunqing Dunqing force-pushed the 11-08-fix_transformer_async-generator-functions_only_transform_object_method_in_exit_function branch from adb6111 to 467dac0 Compare November 8, 2024 02:54
@Dunqing Dunqing force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from c50bbf1 to 28e2f06 Compare November 8, 2024 02:54
@Dunqing Dunqing force-pushed the 11-08-fix_transformer_async-generator-functions_only_transform_object_method_in_exit_function branch from 467dac0 to f1caaa3 Compare November 8, 2024 03:03
@Dunqing Dunqing force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from 28e2f06 to f3308c0 Compare November 8, 2024 03:03
@Boshen Boshen changed the base branch from 11-08-fix_transformer_async-generator-functions_only_transform_object_method_in_exit_function to graphite-base/7201 November 8, 2024 03:15
@Boshen Boshen force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from f3308c0 to 05ef9a7 Compare November 8, 2024 03:22
@Boshen Boshen changed the base branch from graphite-base/7201 to main November 8, 2024 03:23
@Boshen Boshen force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from 05ef9a7 to 4cc1a86 Compare November 8, 2024 03:23
@Dunqing Dunqing force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch 2 times, most recently from 5c08bae to 24fdb61 Compare November 8, 2024 06:49
@Dunqing Dunqing mentioned this pull request Nov 8, 2024
Merged
@Dunqing Dunqing force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from 24fdb61 to e006816 Compare November 8, 2024 06:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 8, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 8, 2024 •
edited
Loading

Merge activity

@Dunqing
feat(transformer/async-to-generator): support inferring the function …
1910227 
…name from the ObjectPropertyValue's key (#7201)

Support for inferring function name from ObjectPropertyValue's key

For example:
```js
({ foo: async function() {} })
```

After this, we will able to infer `foo` for the object method
@Boshen Boshen force-pushed the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch from e006816 to 1910227 Compare November 8, 2024 08:18
@graphite-app graphite-app bot merged commit 1910227 into main Nov 8, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-08-feat_transformer_async-to-generator_support_inferring_the_function_name_from_the_objectpropertyvalue_s_key branch November 8, 2024 08:23
@oxc-bot oxc-bot mentioned this pull request Nov 9, 2024
Merged
Boshen added a commit that referenced this pull request Nov 9, 2024
@oxc-bot @Boshen
release(crates): v0.36.0 (#7227)
de10724 
## [0.36.0] - 2024-11-09

- b11ed2c ast: [**BREAKING**] Remove useless `ObjectProperty::init`
field (#7220) (Boshen)

- 0e4adc1 ast: [**BREAKING**] Remove invalid expressions from
`TSEnumMemberName` (#7219) (Boshen)

- 846711c transformer: [**BREAKING**] Change API to take a
`&TransformOptions` instead of `TransformOptions` (#7213) (Boshen)

- 092de67 types: [**BREAKING**] Append `rest` field into `elements` for
objects and arrays to align with estree (#7212) (ottomated)

- d1d1874 ast: [**BREAKING**] Change `comment.span` to real position
that contain `//` and `/*` (#7154) (Boshen)

- 843bce4 ast: [**BREAKING**] `IdentifierReference::reference_id` return
`ReferenceId` (#7126) (overlookmotel)

### Features

- cc8a191 ast: Methods on AST nodes to get `scope_id` etc (#7127)
(overlookmotel)
- dc0215c ast_tools: Add #[estree(append_to)], remove some custom
serialization code (#7149) (ottomated)
- 9d6cc9d estree: ESTree compatibility for all literals (#7152)
(ottomated)
- b74686c isolated-declarations: Support transform TSExportAssignment
declaration (#7204) (Dunqing)
- ad3a2f5 tasks/compat_data: Generate our own compat table (#7176)
(Boshen)
- b4258ee transformer: Add defaulted `Module::Preserve` option (#7225)
(Boshen)
- 324c3fe transformer: Add `TransformOptions::module` option (#7188)
(Boshen)
- a166a4a transformer: Add esbuild comma separated target API
`--target=es2020,chrome58` (#7210) (Boshen)
- 3a20b90 transformer: Add es target to `engineTargets` (#7193) (Boshen)
- 22898c8 transformer: Warn BigInt when targeting < ES2020 (#7184)
(Boshen)
- a579011 transformer: Add features `ES2018NamedCapturingGroupsRegex`
and `ES2018LookbehindRegex` (#7182) (Boshen)
- 8573f79 transformer: Turn on async_to_generator and
async_generator_functions plugins in enable_all (#7135) (Dunqing)
- df77241 transformer: Enable `ArrowFunctionConverter` in
`async-to-generator` and `async-generator-functions` plugins (#7113)
(Dunqing)
- b6a5750 transformer/arrow-function-converter: Move scope to changed
scope for `this_var` if scope have changed (#7125) (Dunqing)
- 1910227 transformer/async-to-generator: Support inferring the function
name from the ObjectPropertyValue's key (#7201) (Dunqing)
- ffa8604 transformer/async-to-generator: Do not transform await
expression if is not inside async function (#7138) (Dunqing)
- e536d47 transformer/babel: Add support for trying to get the `Module`
from `BabelPlugins` (#7218) (Dunqing)
- 5cfdc05 transformer/typescript: Support transform `export =` and
`import = require(...)` when module is commonjs (#7206) (Dunqing)

### Bug Fixes

- c82b273 transformer/async-generator-functions: Only transform object
method in exit_function (#7200) (Dunqing)
- b2a888d transformer/async-generator-functions: Incorrect
transformation for `for await` if it's not placed in a block (#7148)
(Dunqing)
- 19892ed transformer/async-generator-functions: Transform incorrectly
for `for await` if it's in LabeledStatement (#7147) (Dunqing)
- ede10dc transformer/async-to-generator: Incorrect transform when super
expression is inside async method (#7171) (Dunqing)
- 293d072 transformer/async-to-generator: Only transform object method
in exit_function (#7199) (Dunqing)
- ae692d7 transformer/async_to_generator: Fix checking if function is
class method (#7117) (overlookmotel)
- eea4ab8 transformer/helper-loader: Incorrect `SymbolFlags` for default
import when `SourceType` is script (#7226) (Dunqing)

### Refactor

- d27e14f ast: `AstKind::as_*` methods take `self` (#5546)
(overlookmotel)
- fac5042 ast: Use `scope_id` etc methods (#7130) (overlookmotel)
- a297765 minifier: Use `map` and `and_then` instead of let else (#7178)
(7086cmd)
- fc86703 napi/transform: Change test files to TypeScript (#7221)
(Boshen)
- c5485ae semantic: Add `ancestor_kinds` iterator function (#7217)
(camchenry)
- abf1602 semantic: Rename `iter_parents` to `ancestors` (#7216)
(camchenry)
- 42171eb semantic: Rename `ancestors` to `ancestor_ids` (#7215)
(camchenry)
- de56083 transformer: Add `impl TryFrom<EngineTargets> for EnvOptions`
(#7191) (Boshen)
- 0a43c64 transformer: Move `ESTarget` to its own file (#7189) (Boshen)
- 0e1f12c transformer: Remove unimplemented `EnvOptions::bugfixes`
(#7162) (Boshen)
- a981caf transformer: Add `Engine` enum for `EngineTargets` (#7161)
(Boshen)
- 8340243 transformer: Rename `Query` to `BrowserslistQuery` (#7143)
(Boshen)
- 481f7e6 transformer: Change `Targets` to `EngineTargets` (#7142)
(Boshen)
- 55e6989 transformer: Deserialize engine target strings to specific
keys (#7139) (Boshen)
- fdfd9a4 transformer: Use `scope_id` etc methods (#7128)
(overlookmotel)
- ff8bd50 transformer: Move implementation of ArrowFunction to
common/ArrowFunctionConverter (#7107) (Dunqing)
- 4a515be transformer/arrow-function-coverter: Rename function name and
add some comments to explain confusing parts. (#7203) (Dunqing)
- c307e1b transformer/arrow-functions: Pass `ArenaBox` as function param
(#7169) (overlookmotel)
- 217d433 transformer/arrow-functions: Remove unused `&mut self`
function param (#7165) (overlookmotel)
- 426df71 transformer/arrow-functions: Use `scope_id` method (#7164)
(overlookmotel)
- 11c5e12 transformer/arrow-functions: Correct comments (#7163)
(overlookmotel)
- 1238506 transformer/async-generator-function: Remove inactive
`#[allow(clippy::unused_self)]` attrs (#7167) (overlookmotel)
- 84ee581 transformer/async-generator-functions: Simplify identifying
whether within an async generator function (#7170) (overlookmotel)
- 1b12328 transformer/async-generator-functions: Use `clone` not
`clone_in` on `LabelIdentifier` (#7172) (overlookmotel)
- cd1006f transformer/async-generator-functions: Do not transform yield
expression where inside generator function (#7134) (Dunqing)
- 2c5734d transformer/async-generator-functions: Do not transform await
expression where inside ArrowFunctionExpression (#7132) (Dunqing)
- 5ce83bd transformer/async-generator-functions: Remove dead code for
handle await expression (#7131) (Dunqing)
- e04ee97 transformer/async-generator-functions: Move handling of
`MethodDefinition`'s value to `exit_function` (#7106) (Dunqing)
- b57d5a5 transformer/async-to-generator: Remove unused `&self` function
param (#7166) (overlookmotel)
- f80085c transformer/async-to-generator: Move handling of
`MethodDefinition`'s value to `exit_function` (#7105) (Dunqing)
- e2241e6 transformer/jsx-self: Remove unused `&self` function params
(#7159) (overlookmotel)
- 1dfd241 transformer/optional-catch-binding: Remove inactive
`#[allow(clippy::unused_self)]` attr (#7158) (overlookmotel)
- fd9b44c transformer/typescript: Remove inactive
`#[allow(clippy::unused_self)]` attr (#7160) (overlookmotel)
- cacfb9b traverse: Use `symbol_id` etc methods (#7129) (overlookmotel)

### Styling

- 38a6df6 transformer/arrow-functions: Semicolon after return statements
(#7168) (overlookmotel)
- 64b7e3a transformer/async-generator-functions: Import
`oxc_allocator::Vec` as `ArenaVec` (#7173) (overlookmotel)

### Testing

- be819dd napi/transform: Add test for not default es transform (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @Boshen