Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(allocator/vec2): align min amortized cap size with std #9857

Draft
wants to merge 1 commit into
base: graphite-base/9857
Choose a base branch
from
Draft

perf(allocator/vec2): align min amortized cap size with std #9857

wants to merge 1 commit into from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 18, 2025

No description provided.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Mar 18, 2025
This was referenced Mar 18, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Draft
Draft
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 18, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 18, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #9857 will degrade performances by 3.02%

Comparing 03-18-perf_allocator_vec2_align_min_amortized_cap_size_with_std (01cc973) with 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std (e8c0a03)

Summary

❌ 1 regressions
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ transformer[checker.ts] 23.1 ms 23.8 ms -3.02%

@Dunqing Dunqing mentioned this pull request Mar 18, 2025
Open
10 tasks
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_align_min_amortized_cap_size_with_std branch from 800ce69 to eafa7ae Compare March 18, 2025 08:36
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_replace_self.reserve_1_calls_with_self.grow_one_for_better_efficiency branch from 4dc483f to 9d1db26 Compare March 18, 2025 08:36
@Dunqing Dunqing mentioned this pull request Mar 18, 2025
Merged
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_replace_self.reserve_1_calls_with_self.grow_one_for_better_efficiency branch from 9d1db26 to c94a0f0 Compare March 18, 2025 08:59
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_align_min_amortized_cap_size_with_std branch from eafa7ae to 00f7adb Compare March 18, 2025 08:59
@Dunqing Dunqing changed the base branch from 03-18-perf_allocator_vec2_replace_self.reserve_1_calls_with_self.grow_one_for_better_efficiency to graphite-base/9857 March 18, 2025 10:36
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_align_min_amortized_cap_size_with_std branch from 00f7adb to d354fa1 Compare March 18, 2025 10:58
@Dunqing Dunqing force-pushed the graphite-base/9857 branch 2 times, most recently from 07ac0f1 to 43613e1 Compare March 18, 2025 16:35
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_align_min_amortized_cap_size_with_std branch from d354fa1 to 66bd195 Compare March 18, 2025 16:35
@Dunqing Dunqing changed the base branch from graphite-base/9857 to 03-18-perf_allocator_vec2_replace_self.reserve_1_calls_with_self.grow_one_for_better_efficiency March 18, 2025 16:35
@Dunqing Dunqing marked this pull request as draft March 20, 2025 09:48
@Dunqing Dunqing changed the base branch from 03-18-perf_allocator_vec2_replace_self.reserve_1_calls_with_self.grow_one_for_better_efficiency to graphite-base/9857 March 21, 2025 08:44
@Dunqing Dunqing force-pushed the graphite-base/9857 branch from 43613e1 to e8c0a03 Compare March 21, 2025 08:54
@Dunqing Dunqing force-pushed the 03-18-perf_allocator_vec2_align_min_amortized_cap_size_with_std branch from 66bd195 to 01cc973 Compare March 21, 2025 08:54
@Dunqing Dunqing changed the base branch from graphite-base/9857 to 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std March 21, 2025 08:54
@overlookmotel overlookmotel changed the base branch from 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std to graphite-base/9857 March 25, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dunqing