Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(allocator/vec2): rename parameters and method name to align with std #9858

Merged
merged 1 commit into from
Mar 25, 2025
Merged

refactor(allocator/vec2): rename parameters and method name to align with std #9858

merged 1 commit into from
Mar 25, 2025
+34 −46

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 18, 2025 •
edited
Loading

Pure refactoring, just align with std naming

This was referenced Mar 18, 2025
Merged
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 18, 2025
This was referenced Mar 18, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Draft
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 18, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 18, 2025
Draft
Draft
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 18, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #9858 will not alter performance

Comparing 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std (c971328) with main (6a8c2fd)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing mentioned this pull request Mar 18, 2025
Open
10 tasks
@Dunqing Dunqing force-pushed the 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std branch from 4465ad4 to 2fc0088 Compare March 18, 2025 08:59
@Dunqing Dunqing force-pushed the 03-13-feat_allocator_vec2_align_the_retain_method_with_the_standard_implementation branch from 87ad9b8 to edee838 Compare March 18, 2025 08:59
@Dunqing Dunqing mentioned this pull request Mar 19, 2025
Draft
@Dunqing Dunqing force-pushed the 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std branch from 2fc0088 to e8c0a03 Compare March 21, 2025 08:44
@Dunqing Dunqing force-pushed the 03-13-feat_allocator_vec2_align_the_retain_method_with_the_standard_implementation branch from edee838 to 88a605a Compare March 21, 2025 08:44
@graphite-app graphite-app bot changed the base branch from 03-13-feat_allocator_vec2_align_the_retain_method_with_the_standard_implementation to graphite-base/9858 March 25, 2025 14:06
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Mar 25, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 25, 10:11 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 10:28 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 25, 2:31 PM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Mar 25, 10:44 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 10:51 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 25, 10:57 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
Copy link
Contributor

I had to force push #9752 to solve some doc test failures (doc tests were enabled on this crate after this PR was originally written). I'll rebase this and get it merged once #9752 is merged.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/9858 to main March 25, 2025 14:29
@overlookmotel overlookmotel force-pushed the 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std branch from e8c0a03 to dd17eb4 Compare March 25, 2025 14:44
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@Dunqing
refactor(allocator/vec2): rename parameters and method name to align …
c971328 
…with `std` (#9858)

Pure refactoring, just align with `std` naming
@graphite-app graphite-app bot force-pushed the 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std branch from dd17eb4 to c971328 Compare March 25, 2025 14:51
@graphite-app graphite-app bot merged commit c971328 into main Mar 25, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 03-18-refactor_allocator_vec2_rename_parameters_and_method_name_to_align_with_std branch March 25, 2025 14:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @overlookmotel