Skip to content

Conversation

@david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Apr 11, 2024

Closes #2140

Also fixes NaN% in CapacityBar when both numerator and denominator are zero.

Before

After

image

@vercel
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Apr 12, 2024 5:49am

@david-crespo david-crespo merged commit 83ace42 into main Apr 12, 2024
@david-crespo david-crespo deleted the fix-quote-bytes branch April 12, 2024 14:35
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Apr 14, 2024
oxidecomputer/console@7e34c11...2ba444c

* [2ba444ca](oxidecomputer/console@2ba444ca) smarter warning suppression for unhandled routes in msw
* [0de42104](oxidecomputer/console@0de42104) oxidecomputer/console#2146
* [5cae2111](oxidecomputer/console@5cae2111) turn off links test for now. it freaks me out
* [37470900](oxidecomputer/console@37470900) bump most deps
* [ff67b406](oxidecomputer/console@ff67b406) oxidecomputer/console#2145
* [f1e8f2ee](oxidecomputer/console@f1e8f2ee) oxidecomputer/console#2139
* [31508df8](oxidecomputer/console@31508df8) bring instance networking floating ip detach modal copy in line with floating IPs page
* [a433d71a](oxidecomputer/console@a433d71a) oxidecomputer/console#2130
* [83ace42b](oxidecomputer/console@83ace42b) oxidecomputer/console#2141
* [9270a930](oxidecomputer/console@9270a930) oxidecomputer/console#2134
* [00a03637](oxidecomputer/console@00a03637) update api-diff for better way of calling oxide.ts
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Apr 14, 2024
oxidecomputer/console@7e34c11...2ba444c

* [2ba444ca](oxidecomputer/console@2ba444ca)
smarter warning suppression for unhandled routes in msw
* [0de42104](oxidecomputer/console@0de42104)
oxidecomputer/console#2146
* [5cae2111](oxidecomputer/console@5cae2111)
turn off links test for now. it freaks me out
* [37470900](oxidecomputer/console@37470900)
bump most deps
* [ff67b406](oxidecomputer/console@ff67b406)
oxidecomputer/console#2145
* [f1e8f2ee](oxidecomputer/console@f1e8f2ee)
oxidecomputer/console#2139
* [31508df8](oxidecomputer/console@31508df8)
bring instance networking floating ip detach modal copy in line with
floating IPs page
* [a433d71a](oxidecomputer/console@a433d71a)
oxidecomputer/console#2130
* [83ace42b](oxidecomputer/console@83ace42b)
oxidecomputer/console#2141
* [9270a930](oxidecomputer/console@9270a930)
oxidecomputer/console#2134
* [00a03637](oxidecomputer/console@00a03637)
update api-diff for better way of calling oxide.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Silo creation does not convert from GiB to bytes for quotas

2 participants