Add DocsPopover with page-specific links to docs #2194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Current iteration: |
|
@charliepark the icon next to a document name is slightly misplaced, it should be pushed down a pixel or two :) |
Contributor
Author
|
Latest: |
charliepark
commented
Apr 26, 2024
Contributor
Author
Just noticed this slightly different background color for the different buttons; will want to chat about best approach. |
charliepark
changed the title
Contributor
Author
|
I noticed that the popover scrolls with the page, rather than staying locked to the trigger. You can see this in action here: http://localhost:4000/projects/mock-project/disks I'll need to look into this tomorrow morning; I suspect there's an option we can adjust in the floating-ui configs. |
david-crespo
force-pushed
the
contextual-learn-modal
branch
from
fce5bfb to
30770d6
Compare
Collaborator
|
Animation works! 2024-04-30-docs-popover-anim.mp4 |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 30, 2024
oxidecomputer/console@e7b243b...31d1884 * [31d18845](oxidecomputer/console@31d18845) oxidecomputer/console#2194 * [86c44035](oxidecomputer/console@86c44035) oxidecomputer/console#2199 * [d9adfce3](oxidecomputer/console@d9adfce3) fix npm run start:mock-api by switching to tsx * [042d5ef3](oxidecomputer/console@042d5ef3) oxidecomputer/console#2209 * [e45f2d9a](oxidecomputer/console@e45f2d9a) oxidecomputer/console#2207 * [e8e4f576](oxidecomputer/console@e8e4f576) react 18.3.1 (fix test warnings due to act export)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 1, 2024
oxidecomputer/console@e7b243b...31d1884 * [31d18845](oxidecomputer/console@31d18845) oxidecomputer/console#2194 * [86c44035](oxidecomputer/console@86c44035) oxidecomputer/console#2199 * [d9adfce3](oxidecomputer/console@d9adfce3) fix npm run start:mock-api by switching to tsx * [042d5ef3](oxidecomputer/console@042d5ef3) oxidecomputer/console#2209 * [e45f2d9a](oxidecomputer/console@e45f2d9a) oxidecomputer/console#2207 * [e8e4f576](oxidecomputer/console@e8e4f576) react 18.3.1 (fix test warnings due to act export)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2114
Fixes #2210
This PR introduces new page-specific links to the Oxide Docs.
Here you can see the trigger for the popover in the upper-right corner …
And the popover when it shows up:
