Update copy regarding disk attach / detach requirements #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| Instance must be <span className="text-default">stopped</span> to create a | ||
| disk | ||
| </> | ||
| } |
Collaborator
There was a problem hiding this comment.
could it be worth saying “create and attach” here? it’s the attach that’s the problem, right?
| <>Instance must be in state {detachableStates} before disk can be detached</> | ||
| <> | ||
| Instance must be <span className="text-default">stopped</span> before disk can | ||
| be detached |
Collaborator
There was a problem hiding this comment.
might as well do what the other ones do, fudge it grammatically to save a few words: “instance must be stopped to detach disks” or maybe even “instance must be stopped” by itself? the button is disabled and it says “detach”
david-crespo
approved these changes
Apr 26, 2024
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks good, not particularly attached to my comments!
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 30, 2024
oxidecomputer/console@e7b243b...31d1884 * [31d18845](oxidecomputer/console@31d18845) oxidecomputer/console#2194 * [86c44035](oxidecomputer/console@86c44035) oxidecomputer/console#2199 * [d9adfce3](oxidecomputer/console@d9adfce3) fix npm run start:mock-api by switching to tsx * [042d5ef3](oxidecomputer/console@042d5ef3) oxidecomputer/console#2209 * [e45f2d9a](oxidecomputer/console@e45f2d9a) oxidecomputer/console#2207 * [e8e4f576](oxidecomputer/console@e8e4f576) react 18.3.1 (fix test warnings due to act export)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 1, 2024
oxidecomputer/console@e7b243b...31d1884 * [31d18845](oxidecomputer/console@31d18845) oxidecomputer/console#2194 * [86c44035](oxidecomputer/console@86c44035) oxidecomputer/console#2199 * [d9adfce3](oxidecomputer/console@d9adfce3) fix npm run start:mock-api by switching to tsx * [042d5ef3](oxidecomputer/console@042d5ef3) oxidecomputer/console#2209 * [e45f2d9a](oxidecomputer/console@e45f2d9a) oxidecomputer/console#2207 * [e8e4f576](oxidecomputer/console@e8e4f576) react 18.3.1 (fix test warnings due to act export)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have some copy on the Storage tab of the Instance page, where we tell the user that certain conditions have to be met (the instance has to be stopped) before the user can take specific actions (detaching the disk). There's some other copy that — while technically accurate (probably) — aren't things that the user really cares about in that moment.
This PR updates that view, so that the thing the user needs to know — you need to stop the instance in order to detach the disk, or add a new disk — is more clearly linked to the next step they need to take — stopping the instance.
I'm open to copy suggestions, as always, though I think what I have here is pretty clear.