Extract IpPoolCell so we can use it in other places #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Oct 9, 2024
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Nice. Something worth trying: if (!content) return child on line 88 inside Tooltip. That would eliminate the conditional in the cell and seems like it could be useful elsewhere.
console/app/ui/lib/Tooltip.tsx
Lines 87 to 94 in f0c161d
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 16, 2024
oxidecomputer/console@1733b76...f7d6daf * [f7d6dafd](oxidecomputer/console@f7d6dafd) oxidecomputer/console#2506 * [226d421a](oxidecomputer/console@226d421a) oxidecomputer/console#2505 * [a76ba5f4](oxidecomputer/console@a76ba5f4) oxidecomputer/console#2503 * [63475c6d](oxidecomputer/console@63475c6d) oxidecomputer/console#2501 * [f6e19175](oxidecomputer/console@f6e19175) oxidecomputer/console#2498 * [0a470971](oxidecomputer/console@0a470971) oxidecomputer/console#2492 * [48f3bca4](oxidecomputer/console@48f3bca4) oxidecomputer/console#2493 * [352c8021](oxidecomputer/console@352c8021) oxidecomputer/console#2497 * [f0c161de](oxidecomputer/console@f0c161de) oxidecomputer/console#2496 * [98103a25](oxidecomputer/console@98103a25) oxidecomputer/console#2491
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 24, 2024
oxidecomputer/console@1733b76...f7d6daf * [f7d6dafd](oxidecomputer/console@f7d6dafd) oxidecomputer/console#2506 * [226d421a](oxidecomputer/console@226d421a) oxidecomputer/console#2505 * [a76ba5f4](oxidecomputer/console@a76ba5f4) oxidecomputer/console#2503 * [63475c6d](oxidecomputer/console@63475c6d) oxidecomputer/console#2501 * [f6e19175](oxidecomputer/console@f6e19175) oxidecomputer/console#2498 * [0a470971](oxidecomputer/console@0a470971) oxidecomputer/console#2492 * [48f3bca4](oxidecomputer/console@48f3bca4) oxidecomputer/console#2493 * [352c8021](oxidecomputer/console@352c8021) oxidecomputer/console#2497 * [f0c161de](oxidecomputer/console@f0c161de) oxidecomputer/console#2496 * [98103a25](oxidecomputer/console@98103a25) oxidecomputer/console#2491
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 28, 2024
oxidecomputer/console@1733b76...f7d6daf * [f7d6dafd](oxidecomputer/console@f7d6dafd) oxidecomputer/console#2506 * [226d421a](oxidecomputer/console@226d421a) oxidecomputer/console#2505 * [a76ba5f4](oxidecomputer/console@a76ba5f4) oxidecomputer/console#2503 * [63475c6d](oxidecomputer/console@63475c6d) oxidecomputer/console#2501 * [f6e19175](oxidecomputer/console@f6e19175) oxidecomputer/console#2498 * [0a470971](oxidecomputer/console@0a470971) oxidecomputer/console#2492 * [48f3bca4](oxidecomputer/console@48f3bca4) oxidecomputer/console#2493 * [352c8021](oxidecomputer/console@352c8021) oxidecomputer/console#2497 * [f0c161de](oxidecomputer/console@f0c161de) oxidecomputer/console#2496 * [98103a25](oxidecomputer/console@98103a25) oxidecomputer/console#2491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll likely be using the IpPoolCell in the new Network Gateways page; this extracts it out to its own component.
We were already following the "fetch the list and then seed the ReactQuery cache with relevant data" approach, so this is really just moving the component around.