minor: refactor instanceCan and diskCan for better type safety
#2505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Oct 15, 2024
| // @ts-expect-error typechecker rejects actions that don't exist | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | ||
| diskCan.abc | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
Confirmed the @ts-expect-errors fail on main:
Collaborator
Author
|
Well, recording that video made me realize how to do it the nice way. So that's nice. |
david-crespo
force-pushed
the
refactor-can-test
branch
from
63e7acb to
e0206e0
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 16, 2024
oxidecomputer/console@1733b76...f7d6daf * [f7d6dafd](oxidecomputer/console@f7d6dafd) oxidecomputer/console#2506 * [226d421a](oxidecomputer/console@226d421a) oxidecomputer/console#2505 * [a76ba5f4](oxidecomputer/console@a76ba5f4) oxidecomputer/console#2503 * [63475c6d](oxidecomputer/console@63475c6d) oxidecomputer/console#2501 * [f6e19175](oxidecomputer/console@f6e19175) oxidecomputer/console#2498 * [0a470971](oxidecomputer/console@0a470971) oxidecomputer/console#2492 * [48f3bca4](oxidecomputer/console@48f3bca4) oxidecomputer/console#2493 * [352c8021](oxidecomputer/console@352c8021) oxidecomputer/console#2497 * [f0c161de](oxidecomputer/console@f0c161de) oxidecomputer/console#2496 * [98103a25](oxidecomputer/console@98103a25) oxidecomputer/console#2491
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 24, 2024
oxidecomputer/console@1733b76...f7d6daf * [f7d6dafd](oxidecomputer/console@f7d6dafd) oxidecomputer/console#2506 * [226d421a](oxidecomputer/console@226d421a) oxidecomputer/console#2505 * [a76ba5f4](oxidecomputer/console@a76ba5f4) oxidecomputer/console#2503 * [63475c6d](oxidecomputer/console@63475c6d) oxidecomputer/console#2501 * [f6e19175](oxidecomputer/console@f6e19175) oxidecomputer/console#2498 * [0a470971](oxidecomputer/console@0a470971) oxidecomputer/console#2492 * [48f3bca4](oxidecomputer/console@48f3bca4) oxidecomputer/console#2493 * [352c8021](oxidecomputer/console@352c8021) oxidecomputer/console#2497 * [f0c161de](oxidecomputer/console@f0c161de) oxidecomputer/console#2496 * [98103a25](oxidecomputer/console@98103a25) oxidecomputer/console#2491
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 28, 2024
oxidecomputer/console@1733b76...f7d6daf * [f7d6dafd](oxidecomputer/console@f7d6dafd) oxidecomputer/console#2506 * [226d421a](oxidecomputer/console@226d421a) oxidecomputer/console#2505 * [a76ba5f4](oxidecomputer/console@a76ba5f4) oxidecomputer/console#2503 * [63475c6d](oxidecomputer/console@63475c6d) oxidecomputer/console#2501 * [f6e19175](oxidecomputer/console@f6e19175) oxidecomputer/console#2498 * [0a470971](oxidecomputer/console@0a470971) oxidecomputer/console#2492 * [48f3bca4](oxidecomputer/console@48f3bca4) oxidecomputer/console#2493 * [352c8021](oxidecomputer/console@352c8021) oxidecomputer/console#2497 * [f0c161de](oxidecomputer/console@f0c161de) oxidecomputer/console#2496 * [98103a25](oxidecomputer/console@98103a25) oxidecomputer/console#2491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on #2361 that
instanceCanallows any string as a key, which means you can doinstanceCan.detaaaaaach(instance)and not get a type error. The goal here was to make that a type error without affecting the API, so we don't have to change any call sites.After some back and forth with myself around several ways one could make this work, I landed on this, which is more verbose than I prefer, but it's fine.I did it.Rather than try to explain the other stuff I tried, here is a fun and exciting video of me suffering.
2024-10-15-typescript-pain.mp4