minor: Delete inapplicable z-index e2e test #2563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 19, 2024
oxidecomputer/console@0517a28...6fe6936 * [6fe6936d](oxidecomputer/console@6fe6936d) oxidecomputer/console#2328 * [fcd34418](oxidecomputer/console@fcd34418) oxidecomputer/console#2563 * [6e389ec6](oxidecomputer/console@6e389ec6) oxidecomputer/console#2561 * [41c4c5db](oxidecomputer/console@41c4c5db) oxidecomputer/console#2560 * [92472558](oxidecomputer/console@92472558) oxidecomputer/console#2562 * [9b60d5c9](oxidecomputer/console@9b60d5c9) oxidecomputer/console#2559 * [1e0486c2](oxidecomputer/console@1e0486c2) chore: npm audit fix * [7d35d268](oxidecomputer/console@7d35d268) oxidecomputer/console#2544
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 19, 2024
oxidecomputer/console@0517a28...6fe6936 * [6fe6936d](oxidecomputer/console@6fe6936d) oxidecomputer/console#2328 * [fcd34418](oxidecomputer/console@fcd34418) oxidecomputer/console#2563 * [6e389ec6](oxidecomputer/console@6e389ec6) oxidecomputer/console#2561 * [41c4c5db](oxidecomputer/console@41c4c5db) oxidecomputer/console#2560 * [92472558](oxidecomputer/console@92472558) oxidecomputer/console#2562 * [9b60d5c9](oxidecomputer/console@9b60d5c9) oxidecomputer/console#2559 * [1e0486c2](oxidecomputer/console@1e0486c2) chore: npm audit fix * [7d35d268](oxidecomputer/console@7d35d268) oxidecomputer/console#2544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this test in #1747, @charliepark's epic PR from before he started. In #2522 we specifically changed it so that the dropdowns are on top of the topbar. I'm not really clear on why this test continues to pass, but also flakes. It suggests it's a bad test. So I am fine deleting it.