Skip to content

minor: Delete inapplicable z-index e2e test #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Nov 19, 2024
Merged

minor: Delete inapplicable z-index e2e test #2563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions test/e2e/z-index.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,38 +9,6 @@ import { expect, test } from '@playwright/test'

import { expectObscured, stopInstance } from './utils'

test('Dropdown content can scroll off page and doesn’t hide TopBar', async ({ page }) => {
// load the page
await page.goto('/utilization')
await expect(page.getByRole('heading', { name: 'Utilization' })).toBeVisible()

const button = page.getByRole('button', { name: 'All projects' })

// click on the 'All projects' dropdown
await button.click()
const options = ['All projects', 'mock-project', 'other-project']
for (const name of options) {
const option = page.getByRole('option', { name })
await expect(option).toBeVisible()
await expect(option).toBeInViewport()
}

// scroll the page down just enough that the button and the top item are off
// screen, but the bottom item is not
await page.mouse.wheel(0, 480)

// if we don't do this, the test doesn't wait long enough for the following
// assertions to become true
await expect(button).not.toBeInViewport()

// now the top the listbox option is obscured by the topbar
await expectObscured(page.getByRole('option', { name: 'All projects' }))

// but we can still click the bottom one
await page.getByRole('option', { name: 'other-project' }).click()
await expect(page.getByRole('button', { name: 'other-project' })).toBeVisible()
})

test('Dropdown content in SidebarModal shows on screen', async ({ page }) => {
// go to an instance’s Network Interfaces page
await page.goto('/projects/mock-project/instances/db1/networking')
Expand Down
Loading