Add dummy test for snapshot_exists
#1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
approved these changes
Oct 7, 2025
mkeeter
added a commit
that referenced
this pull request
Oct 13, 2025
Both #1780 and #1778 fixed the `snapshot_exists` function only being used on illumos. Unfortunately, they fixed it in mutually incompatible ways: #1780 added a trivial test to exercise it, while #1778 added an `expect(unused)` annotation. The combination of these two produces a warning on non-illumos machines.
iximeow
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 13, 2025
Propolis changes: * oxidecomputer/propolis#950 * oxidecomputer/propolis#952 * oxidecomputer/propolis#951 * oxidecomputer/propolis#954 * oxidecomputer/propolis#957 * oxidecomputer/propolis#960 * oxidecomputer/propolis#961 * oxidecomputer/propolis#955 Crucible changes: * oxidecomputer/crucible#1773 * oxidecomputer/crucible#1774 * oxidecomputer/crucible#1780 * oxidecomputer/crucible#1778
iximeow
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 18, 2025
Propolis changes: * oxidecomputer/propolis#950 * oxidecomputer/propolis#952 * oxidecomputer/propolis#951 * oxidecomputer/propolis#954 * oxidecomputer/propolis#957 * oxidecomputer/propolis#960 * oxidecomputer/propolis#961 * oxidecomputer/propolis#955 Crucible changes: * oxidecomputer/crucible#1773 * oxidecomputer/crucible#1774 * oxidecomputer/crucible#1780 * oxidecomputer/crucible#1778 Crucible shouldn't have functional changes here, Propolis' big ones are @sunshowers' work moving Propolis to versioned APIs, plus propolis#960 turning the crank on MAXCPU. propolis#961 changes the initial Milan CPU profile one last time before the release in service of propolis#959. Propolis will clear [this bit](https://github.com/oxidecomputer/omicron/blob/d74f5e3f1ae0a378dcdb9795a0ada2426702b046/nexus/src/app/instance_platform/cpu_platform.rs#L423). Later we want to actually set up leaf 8000_001E, so after this merges I'll have a followup to remove that leaf from the inital Milan definition to keep the profile constant when `propolis-server` is smarter about the leaf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents warnings about unused functions on non-illumos machines.