-
Notifications
You must be signed in to change notification settings - Fork 27
[propolis] make API versioned #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[propolis] make API versioned #955
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
|
looking at the downloading the log file tarball, within That looks like the phd-runner is somehow using a Progenitor version < 0.10.0 (ie before the first version that sent the |
|
Ah, so the issue is that this code is constructing its own client which of course won't include the API header. propolis/bin/propolis-server/src/lib/migrate/destination.rs Lines 82 to 93 in 6b161e8
Going to dig into what to do here. |
|
So this is propolis-server instances making direct requests to other propolis-server instances to start migrations. I'm not sure how this would work in the context of self-service update, where the propolis-server instances might be on different versions. There are two parts to this:
|
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
|
We addressed the above concern in #957. |
|
Ah so the migrate-from-base test will fail until the api-version header is passed in. So I guess I'll need to split that change into its own PR. |
Split out of #955 -- for the `phd-run-migrate-from-base` tests to work, this has to be in its own PR that's landed first.
Created using spr 1.3.6-beta.1
Propolis changes: * oxidecomputer/propolis#950 * oxidecomputer/propolis#952 * oxidecomputer/propolis#951 * oxidecomputer/propolis#954 * oxidecomputer/propolis#957 * oxidecomputer/propolis#960 * oxidecomputer/propolis#961 * oxidecomputer/propolis#955 Crucible changes: * oxidecomputer/crucible#1773 * oxidecomputer/crucible#1774 * oxidecomputer/crucible#1780 * oxidecomputer/crucible#1778
Propolis changes: * oxidecomputer/propolis#950 * oxidecomputer/propolis#952 * oxidecomputer/propolis#951 * oxidecomputer/propolis#954 * oxidecomputer/propolis#957 * oxidecomputer/propolis#960 * oxidecomputer/propolis#961 * oxidecomputer/propolis#955 Crucible changes: * oxidecomputer/crucible#1773 * oxidecomputer/crucible#1774 * oxidecomputer/crucible#1780 * oxidecomputer/crucible#1778 Crucible shouldn't have functional changes here, Propolis' big ones are @sunshowers' work moving Propolis to versioned APIs, plus propolis#960 turning the crank on MAXCPU. propolis#961 changes the initial Milan CPU profile one last time before the release in service of propolis#959. Propolis will clear [this bit](https://github.com/oxidecomputer/omicron/blob/d74f5e3f1ae0a378dcdb9795a0ada2426702b046/nexus/src/app/instance_platform/cpu_platform.rs#L423). Later we want to actually set up leaf 8000_001E, so after this merges I'll have a followup to remove that leaf from the inital Milan definition to keep the profile constant when `propolis-server` is smarter about the leaf.
Last part of oxidecomputer/omicron#8922 for Propolis.