Skip to content

Conversation

@sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Aug 29, 2025

We're going to migrate dpd to an API trait which requires this additional indent. (This PR only contains whitespace changes.)

This commit will be added to .git-blame-ignore-revs which will help preserve blame.

Created using spr 1.3.6-beta.1
@Nieuwejaar
Copy link
Collaborator

We're going to migrate dpd to an API trait which requires this additional indent. (This PR only contains whitespace changes.)

Could you expand on this? What do you mean it requires an additional indent? We're making some change where whitespace becomes syntactic? Like Python?

@sunshowers
Copy link
Contributor Author

We're going to migrate dpd to an API trait which requires this additional indent. (This PR only contains whitespace changes.)

Could you expand on this? What do you mean it requires an additional indent? We're making some change where whitespace becomes syntactic? Like Python?

Oh no, it just means that these methods go inside an impl Trait block. See #116 for how this works.

@sunshowers sunshowers merged commit 7cb947f into main Aug 31, 2025
6 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/1n-dpd-add-an-indent-level-to-api_serverrs branch August 31, 2025 19:25
sunshowers added a commit to oxidecomputer/lldp that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants