Skip to content

Section anchor fix #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminleonard merged 3 commits into from
Feb 25, 2025
Merged

Section anchor fix #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54b4d88
Also include `sectionanchor`
benjaminleonard Feb 25, 2025
713264f
Try stripping links from code items in outline
benjaminleonard Feb 25, 2025
93b0949
Also strip on small screen outline
benjaminleonard Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions components/src/asciidoc/TableOfContents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
* Copyright Oxide Computer Company
*/
import { DirectionRightIcon } from '@/icons/react'
import type { DocumentSection } from '@oxide/react-asciidoc'
import { type DocumentSection, parse } from '@oxide/react-asciidoc'
import * as Accordion from '@radix-ui/react-accordion'
import cn from 'classnames'
import { Fragment, useCallback, useEffect, useMemo, useRef, useState } from 'react'

import { stripAnchors } from './Section'

export function useIntersectionObserver(
elements: Element[],
callback: IntersectionObserverCallback,
Expand Down Expand Up @@ -283,7 +285,7 @@ export const DesktopOutline = ({
paddingLeft: `${0.5 + item.level * 0.5}rem`,
}}
>
<span dangerouslySetInnerHTML={{ __html: item.title }} />
{parse(stripAnchors(item.title))}
</a>
</li>
{item.sections && renderToc(item.sections)}
Expand Down Expand Up @@ -328,7 +330,7 @@ export const SmallScreenOutline = ({
paddingLeft: `${0.5 + item.level * 0.5}rem`,
}}
>
<span dangerouslySetInnerHTML={{ __html: item.title }} />
{parse(stripAnchors(item.title))}
</a>
</li>
{item.sections && renderToc(item.sections)}
Expand Down
3 changes: 2 additions & 1 deletion components/src/assets/asciidoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@
@apply mb-2 mt-8 text-sans-lg text-raise;
}

.anchor {
.anchor,
.sectionanchor {
position: absolute;
margin-top: calc(var(--header-height) * -1 - 20px);
visibility: hidden;
Expand Down
Loading