Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal_dns tests don't clean up after themselves #990

Closed
davepacheco opened this issue Apr 28, 2022 · 1 comment · Fixed by #993
Closed

internal_dns tests don't clean up after themselves #990

davepacheco opened this issue Apr 28, 2022 · 1 comment · Fixed by #993
Assignees

Comments

@davepacheco
Copy link
Collaborator

davepacheco commented Apr 28, 2022

It looks like the internal DNS tests spawn a separate tokio task to run the DNS server and never clean this up. They also don't clean up the files they create in $TMPDIR (which is hard to fix because the server is still running). This latter part makes it hard for us to write a check that no tests leave detritus in $TMPDIR, which makes it easy to create more tests that leave stuff there.

@davepacheco
Copy link
Collaborator Author

@rcgoodfellow, is this something you could look into? It's possible the patterns we use for Nexus integration tests will be useful here. They have a "test context" object that has a cleanup function that tears things down. We also wrote a proc macro to make it easier to use so you don't need to remember to call the cleanup function. All this might be overkill here though.

@smklein smklein self-assigned this Apr 28, 2022
leftwo pushed a commit that referenced this issue Oct 16, 2023
Propolis changes:
PHD: refactor & add support Propolis server "environments" (#547)
Begin making Accessor interface more robust
Update Crucible and Omicron deps for Hakari fixes
Add cloud-init volume generation to standalone
Use specified toolchain version for all GHA checks
Use params to configure rust-toolchain in GHA
Update and lock GHA dependencies

Crucible changes:
Use regions_dataset path for apply_smf (#1000)
Don't unwrap when we can't create a dataset (#992)
Fix tests and update log messages. (#995)
Better backpressure (#990)
Update Rust crate proptest to 1.3.1 (#977)
Read only downstairs can skip Live Repair (#984)
Update Rust crate expectorate to 1.1.0 (#975)
Add trait for `ExtentInner` (#982)
report backpressure in upstairs_info dtrace probe (#987)
Support multiple downstairs operations in GtoS (#985)
leftwo added a commit that referenced this issue Oct 16, 2023
Propolis changes:
PHD: refactor & add support Propolis server "environments" (#547) Begin
making Accessor interface more robust
Update Crucible and Omicron deps for Hakari fixes
Add cloud-init volume generation to standalone
Use specified toolchain version for all GHA checks Use params to
configure rust-toolchain in GHA
Update and lock GHA dependencies

Crucible changes:
Use regions_dataset path for apply_smf (#1000)
Don't unwrap when we can't create a dataset (#992) Fix tests and update
log messages. (#995)
Better backpressure (#990)
Update Rust crate proptest to 1.3.1 (#977)
Read only downstairs can skip Live Repair (#984)
Update Rust crate expectorate to 1.1.0 (#975)
Add trait for `ExtentInner` (#982)
report backpressure in upstairs_info dtrace probe (#987) Support
multiple downstairs operations in GtoS (#985)

---------

Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants