Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal-dns] Cleanup server/storage on successful test run #993

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[internal-dns] Cleanup server/storage on successful test run #993

merged 1 commit into from
Apr 28, 2022

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Apr 28, 2022 •
edited
Loading

Fixes #990

Easy repro:

TMPDIR=/home/smklein/dangerzone cargo test -p internal-dns

Before: On success, the temporary directory grew. After: It's empty.

@smklein smklein requested a review from davepacheco April 28, 2022 20:35
davepacheco
davepacheco approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.

@smklein smklein enabled auto-merge (squash) April 28, 2022 20:38
@smklein smklein merged commit 1aaf2a2 into main Apr 28, 2022
@smklein smklein deleted the dns-test-cleanup branch April 28, 2022 21:20
@davepacheco davepacheco mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepacheco davepacheco davepacheco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal_dns tests don't clean up after themselves
2 participants
@smklein @davepacheco