-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS handoff, Nexus doing svc management, DNS integration #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2022
smklein
changed the title
[WIP] RSS handoff, Nexus doing svc management, etc
[WIP] RSS handoff, Nexus doing svc management, DNS integration
Jun 16, 2022
smklein
added a commit
that referenced
this pull request
Jun 24, 2022
Adds utilities in the internal DNS client library to: - Encourage correct usage of SRV / AAAA names (See: RFD 248) - Provide a "single point of entry" for updating multiple DNS servers This PR has been pulled out of #1216 , where it is used in both Nexus and RSS
smklein
added a commit
that referenced
this pull request
Jun 26, 2022
This PR is an incremental step towards #1216 By setting DNS records during RSS initialization, clients can begin the process of looking up services using the DNS resolver.
smklein
added a commit
that referenced
this pull request
Jun 26, 2022
Part of #1216 - Provide an ID and address as a deployment, not package-time arguments - Optionally resolve Nexus and Clickhouse's IP addresses by DNS
smklein
added a commit
that referenced
this pull request
Jun 27, 2022
Part of #1216 - Populates Rack row in DB during initialization - Modifies Rack-based lookups to avoid relying on in-memory cache
smklein
added a commit
that referenced
this pull request
Jul 5, 2022
Part of #1216 - Optionally resolve services by DNS name. This will be necessary to perform handoff from RSS, when the addresses of these services are not hard-coded.
Closing in favor of #1541 , which itself is being split into smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements RSS handoff to Nexus, and also puts Nexus in charge of service management (by toggling the "background tasks" to "on"). Additionally, it propagates usage of internal DNS, as IP addresses become less stable.
This is one of the "final" PRs in a long chain of dependencies. To properly implement RSS handoff, most of the hard-coded services within RSS should be launched by Nexus, but the amount of information necessary for Nexus to successfully rebalance services on the rack is non-trivial.
What follows is a list of pre-requisites, with links to their associated PRs:
Fixes #732
Fixes #1148