[internal-dns] Avoid 'picking ports' #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
jgallagher
approved these changes
Jun 21, 2022
leftwo
added a commit
that referenced
this pull request
Apr 2, 2024
Crucible Increase max backpressure again (Crucible issue #1243) Bump backpressure delay for byte-based backpressure (Crucible issue #1240) `crutest` cleaning; adding rand-read/write tests (Crucible issue #1233) Propolis changes, just the above crucible bits. Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1200
The
internal-dnscrate includes two servers: a "DNS server" and a "Dropshot server". This change refactors the launching of both to ensure that their ports are queryable, especially under tests conditions where they are now set to "port zero" (let the OS pick for us).This PR also removes the dependency on the "port-picker" crate.